-
Notifications
You must be signed in to change notification settings - Fork 1
docs: sync env var docs with what the code reads #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
turbomam
wants to merge
6
commits into
main
Choose a base branch
from
readme-env-var-sync
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2b25de3
docs: sync env var docs with what the code reads
turbomam 601c8c3
docs: fix .env.example region placeholder and misleading comment
turbomam 667f022
Potential fix for pull request finding
hesspnnl 4a34157
remove docker documentation
hesspnnl 82f480c
Merge branch 'main' of https://github.com/microbiomedata/nmdc-metadat…
hesspnnl 0f86748
remove project structure graph - hard to maintain
hesspnnl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caufieldjh @turbomam I did not notice this before, but is there a reason there are so many places to declare gcp region? can we change this to just GCP_REGION ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with all things GCP, the answer is "yes and no". I think the values can be different (https://docs.cloud.google.com/gemini-enterprise-agent-platform/resources/locations kinda gets into this but doesn't fully answer the question).
For our purposes I think it's enough just to set the project ID and region.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I am asking because in this case they are filling the same value... to me this indicates they are not actually different. At least how we are using them