Skip BRITE terms #1409
Merged
Skip BRITE terms #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marySalvi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1385
Changes
Explicitly skip BRITE hierarchy terms that don't have any children.
Problem
The data portal uses a JSON blob from https://www.genome.jp/kegg-bin/download_htext?htext=ko00001&format=json to populate its tables of KO terms. It appears as though this file contains KO terms grouped by Brite hierarchies. Ingest code appears to anticipate this, and does not add rows for parent nodes that don't have children.
This is a problem since there is one parent node without children that we want to skip, since we don't support the full Brite hierarchy at this time. This new change handles the issue by safeguarding against this specific case.