Use STORAGE_EMULATOR_HOST environment variable to bypass ADC validation locally
#1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why this typecheck error didn't occur on the branch that introduced this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, I made it so developers no longer have to have an Application Default Credentials file (i.e.
application_default_credentials.json) when doing local development. I have updated thedocker-compose.ymlfile anddocs/development.mdfiles to the extent necessary to accomplish this.However, there may now be some redundancy between environment variables. I think, once the Google Cloud SDK sees the
STORAGE_EMULATOR_HOSTenvironment variable, it will use that variable's value as the host. That seems to me to be redundant with the booleanGCS_USE_FAKEenvironment variable. I want to review this with @pkalita-lbl (handing it off would also be OK with me).I also made a totally unrelated change (in commit d42887c) because the
typechecktox step was failing on GHA. I don't know why it didn't fail on the branch that introduced that code, given that it failed on this branch. 🤷