Skip to content

Conversation

@samobermiller
Copy link
Collaborator

@samobermiller samobermiller commented Dec 5, 2025

Closes microbiomedata/issues#1497

  • UpdatesRequired status is updated to InProgress when submission is saved, regardless of if user has a current role on the submission
  • The status change from UpdatesRequired to InProgress was being captured in postgres but required the user to refresh the page so the Submit button was available. I added a simple endpoint to get submission status from postgres so status can be refreshed on Harmonizer.vue.
  • The logic for the Submit button on Harmonizer.vue was getting more confusing, so I reformatted the various factors (owner/admin, submission status, validated tabs, already submitted) are all addressed in one variable SubmissionState

…ardless-of-admin-or-submitter-resuming-a-submission-for-updates
Copy link
Collaborator

@JamesTessmer JamesTessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything works, I don't see any issues with the code so I think it's good to go

…ardless-of-admin-or-submitter-resuming-a-submission-for-updates
@pkalita-lbl pkalita-lbl changed the title 1497 status should change to in progress regardless of admin or submitter resuming a submission for updates Change submission status to In Progress regardless of who makes updates Dec 9, 2025
@pkalita-lbl
Copy link
Collaborator

@samobermiller I pushed a few commits that do the following:

  • Update the incrementalSaveRecord and submit functions to take the response body of API requests and feed it back into frontend state. This allows the frontend to stay in sync with modifications that the backend makes. The advantage here is that we can expand the types of automatic backend updates we do in the future without (hopefully) having to make additional frontend changes. This did require updating a few computed and watch callbacks to be a little more picky about when we update reactive state. There is still a bit of a pre-existing reactive rat's nest going on here that I'm not prepared to fully detangle in this PR.
  • Expand the submissionState computed ref that you created so that specific reasons can be shown in the tooltip displayed with the Submit button is disabled.
  • Remove the now-unused GET /api/metadata_submission/{id}/status endpoint 😢

Please give that a test and let me know if you see any issues.

@samobermiller
Copy link
Collaborator Author

samobermiller commented Dec 9, 2025

Looks good to me! Are you ready for it to be merged in @pkalita-lbl ?

@pkalita-lbl pkalita-lbl merged commit fbe3b7d into main Dec 9, 2025
2 checks passed
@pkalita-lbl pkalita-lbl deleted the 1497-status-should-change-to-in-progress-regardless-of-admin-or-submitter-resuming-a-submission-for-updates branch December 9, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Status should change to 'in progress' regardless of admin or submitter resuming a submission for updates

4 participants