Skip to content

Conversation

@pkalita-lbl
Copy link
Collaborator

Fixes #1875

DataHarmonizer needs a container (not necessarily the direct parent, but some ancestor element) with a fixed height in order to work properly. We set the height on the element that contains the stepper header, the validation controls, DataHarmonizer itself and the help sidebar, and the footer. Currently we set the height of that element as the window height (100vh) minus the main application bar height (APP_HEADER_HEIGHT). The problem is that this doesn't take into account the height of the site banner which is sometimes shown. This element is outside of the fixed-height container, so it needs to be taken into account as well.

These changes are a little more complex than I would have hoped, but other options I looked at would involve touching the layout of all pages. Here's the summary of what's happening here.

  1. The site banner (AppBanner) now computes its own height and exposes that as a value that the component that renders AppBanner can access.
  2. SubmissionView renders some common elements for all Submission Portal pages, including AppBanner. It uses a ref to get the height of the AppBanner component and uses provide to make that value available to its component tree.
  3. HarmonizerView is where the AppBanner height is needed, so it uses inject to get the value. It uses the value when setting the height of the fixed-height container.

Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this. Bummer that it ended up being more complex than we had hoped. From my perspective, the banner, itself, is "on the table" (eligible) for being redesigned reimplemented , in case one of us feels like revisiting this in the future.

@eecavanna
Copy link
Collaborator

(I like the way the banner looks — I just mean that we may be able to overhaul how it's implemented in order to make it easier to integrate into the submission portal.)

@pkalita-lbl
Copy link
Collaborator Author

the banner, itself, is "on the table" (eligible) for being redesigned reimplemented , in case one of us feels like revisiting this in the future.

Yeah I totally agree. It has always seemed a little odd to me that individual pages have to render their own <AppBanner> and <v-main>. It seems like that should be done once in App.vue. But that's the "touching everything" type of change I backed away from for now.

@pkalita-lbl pkalita-lbl merged commit d28b344 into main Dec 5, 2025
2 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-1875-data-harmonizer-rows branch December 5, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to see bottom-most rows of DataHarmonizer

3 participants