Introduce config variable used to specify Sentry environment name #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codytodonnell
approved these changes
Dec 17, 2025
Collaborator
codytodonnell
left a comment
codytodonnell
left a comment
There was a problem hiding this comment.
This all looks and sounds good to me. I made one comment about the source of settings.sentry_environment
eecavanna
deleted the
1790-define-sentry-environment-value-based-upon-deployment-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, I introduced a new Sentry-related configuration variable named
sentry_environment(the corresponding environment variable is namedNMDC_SENTRY_ENVIRONMENT).The application owner can use it to specify the name of the environment on Sentry in which they want data from this deployment to be shown. The default value, and the example values in the comment, were copied from nmdc-runtime (where they were deliberately chosen a few weeks ago).
Today, on
main, data sent by all deployments of this application are shown in the Sentry environment named "production"—that's because that's the default environment name and we weren't customizing it.The changes being introduced via this branch will allow us to customize that (for future data, not past data). In our case, we'd add it to our helm chart "values YAML" files (as we've done for the Runtime already).
Finally, note that the changes on this branch only affect the backend. The frontend has its own Sentry configuration and there is a ticket here about refining it.