Use the shared MoreMenuButton and ButtonGroup seam - #1266
Merged
Conversation
|
Preview build will be at |
Upgrade to @microbit/ui@0.1.0-alpha.30 @microbit/ui's ButtonGroup now draws the seam between attached buttons itself: a 1px hairline in the variant's border colour, or a gap where the variant has no border to lend. That is what the split buttons here already hand-wrote — a `borderRight` and a `borderLeft` either side of the group's -1px overlap — so the save and send buttons lose their local borders, and MoreMenuButton goes up to the shared package with them. The zoom and undo/redo pills drop their gray.10 dividers for the same reason. `neutral` has no border, so their seam is now a gap showing the page through rather than a near-white line drawn over the grey; on this surface that is the same pixels. No visual change intended. See microbit-foundation/ui#22
microbit-matt-hillsdon
force-pushed
the
button-group-seam
branch
from
August 16, 2026 17:28
30aaec8 to
09ce7f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@microbit/ui's ButtonGroup now draws the seam between attached buttons itself: a 1px hairline in the variant's border colour, or a gap where the variant has no border to lend. That is what the split buttons here already hand-wrote — a
borderRightand aborderLefteither side of the group's -1px overlap — so the save and send buttons lose their local borders, and MoreMenuButton goes up to the shared package with them.The zoom and undo/redo pills drop their gray.10 dividers for the same reason.
neutralhas no border, so their seam is now a gap showing the page through rather than a near-white line drawn over the grey; on this surface that is the same pixels.No visual change intended.
See microbit-foundation/ui#22