baseline metrics in CircuitBreakerTelemetryTest #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `baselineMetrics()` after creating the `TelemetryMetricGetter` was missing in this test. Funnily enough, the MP Metrics counterpart of this test (`CircuitBreakerMetricTest`) baselines metrics correctly.
|
Can one of the admins verify this patch? |
Ladicek
added a commit
to Ladicek/quarkus
that referenced
this pull request
Mar 5, 2025
One TCK test remains excluded, because it has a bug [1]. [1] microprofile/microprofile-fault-tolerance#655
Emily-Jiang
approved these changes
Mar 6, 2025
|
@eclipse-microprofile-bot test this please |
Azquelt
approved these changes
Mar 6, 2025
Ladicek
added a commit
to Ladicek/quarkus
that referenced
this pull request
Mar 7, 2025
This requires propagating the "metrics enabled at build time" information through the `OpenTelemetrySdkBuildItem`. I took the liberty to also add the tracing and logging build time enablement information, even though I have no use for it at the moment. One TCK test remains excluded, because it has a bug [1][2]. [1] microprofile/microprofile-fault-tolerance#656 [2] microprofile/microprofile-fault-tolerance#655
There is not a lot of places in the MicroProfile Fault Tolerance TCK that require executing some logic before each `@Test` method, but all of them use `@BeforeMethod`. The only exception is `CircuitBreakerMetricTest` and `CircuitBreakerTelemetryTest`, which use `@BeforeTest`. However, `@BeforeTest` in TestNG is nothing like `@BeforeTest` in JUnit -- in TestNG, it means before the `<test>` tag in `testng.xml`. This commit replaces the usage of `@BeforeTest` with `@BeforeMethod`. If the method was supposed to be called once before the test class, the proper annotation would be `@BeforeClass`, but this test class has exactly one `@Test` method, so it doesn't matter. If it had multiple, `@BeforeMethod` would actually be more appropriate, because it brings the circuit breaker into the initial (closed) state, regardless of the state it is currently in.
|
Added an extra commit that replaces |
Azquelt
approved these changes
Mar 7, 2025
|
Thanks, I think this makes sense. I agree the cleanup in this method probably isn't necessary since the test class only has one test method, but the current behaviour (where the |
|
I'll merge this on Monday unless any objections are raised and then we can do a service release. |
brunobat
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
baselineMetrics()after creating theTelemetryMetricGetterwas missing in this test. Funnily enough, the MP Metrics counterpart of this test (CircuitBreakerMetricTest) baselines metrics correctly.Fixes #656