-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Action Versions #3872
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 3645dc5. ♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/8249878251 (with refid (in response to this comment from @wojciechcloudkubed) |
@wojciechcloudkubed There's no point in running a test deployment cycle (like with the / test command) when you update the pr_bot or the tre_deploy* workflows as those run from the main branch. |
What would be the best approach to test it? @tamirkamara |
pull_request: | ||
branches: | ||
- main | ||
- 'feature/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marrobi I notice some deviation in linting here. Are these changes ok or is there a linter you would ideally like us to use? cc @wojciechcloudkubed @Danny-Cooke-CK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github Actions are already checked here -
VALIDATE_GITHUB_ACTIONS: true |
I typically try to check in my fork of the repo. Unless @tamirkamara has a better way to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - suggest test it on a fork before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #3847
What is being addressed
Update GitHub Action Versions to the latest ones
Acceptance criteria