Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Action Versions #3872

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/devcontainer_run_command/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ runs:
echo "AZURE_ENVIRONMENT=$azure_env" >> $GITHUB_ENV

- name: Azure Login
uses: azure/login@v1
uses: azure/login@v2
if: contains(inputs.COMMAND, 'bootstrap') != true
with:
creds: ${{ inputs.AZURE_CREDENTIALS }}
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/build_docker_images.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
name: Docker build

on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
pull_request:
branches:
- main
- 'feature/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marrobi I notice some deviation in linting here. Are these changes ok or is there a linter you would ideally like us to use? cc @wojciechcloudkubed @Danny-Cooke-CK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github Actions are already checked here -

VALIDATE_GITHUB_ACTIONS: true

- "feature/**"
workflow_dispatch:

# for each ref (branch/pr) run just the most recent, cancel
Expand All @@ -27,12 +27,12 @@ jobs:
path: ${{ github.event_path }}

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Filter changes
uses: dorny/paths-filter@v2
uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
if: |
(steps.filter.outputs.api == 'true'
|| github.event_name == 'workflow_dispatch')
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./api_app/
file: ./api_app/Dockerfile
Expand All @@ -116,7 +116,7 @@ jobs:

- name: "Check pytest failure file existence"
id: check_api_test_result
uses: andstor/file-existence-action@v2
uses: andstor/file-existence-action@v3
with:
files: "test-results/pytest_api_unit_failed"

Expand All @@ -125,7 +125,7 @@ jobs:
(steps.filter.outputs.api == 'true'
|| github.event_name == 'workflow_dispatch')
&& steps.check_api_test_result.outputs.files_exists == 'false'
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./api_app/
file: ./api_app/Dockerfile
Expand All @@ -136,7 +136,7 @@ jobs:
if: |
(steps.filter.outputs.resource_processor == 'true'
|| github.event_name == 'workflow_dispatch')
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./resource_processor
file: ./resource_processor/vmss_porter/Dockerfile
Expand All @@ -147,7 +147,7 @@ jobs:
if: |
(steps.filter.outputs.guacamole_server == 'true'
|| github.event_name == 'workflow_dispatch')
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./templates/workspace_services/guacamole/guacamole-server
file: ./templates/workspace_services/guacamole/guacamole-server/docker/Dockerfile
Expand All @@ -158,7 +158,7 @@ jobs:

- name: "Check maven failure file existence"
id: check_maven_test_result
uses: andstor/file-existence-action@v2
uses: andstor/file-existence-action@v3
with:
files: "test-results/guacamole_package_failed"

Expand All @@ -167,7 +167,7 @@ jobs:
(steps.filter.outputs.guacamole_server == 'true'
|| github.event_name == 'workflow_dispatch')
&& steps.check_maven_test_result.outputs.files_exists == 'false'
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./templates/workspace_services/guacamole/guacamole-server
file: ./templates/workspace_services/guacamole/guacamole-server/docker/Dockerfile
Expand All @@ -178,7 +178,7 @@ jobs:
if: |
(steps.filter.outputs.gitea == 'true'
|| github.event_name == 'workflow_dispatch')
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./templates/shared_services/gitea/docker
file: ./templates/shared_services/gitea/docker/Dockerfile
Expand All @@ -195,7 +195,7 @@ jobs:
if: |
(steps.filter.outputs.airlock_processor == 'true'
|| github.event_name == 'workflow_dispatch')
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./airlock_processor/
file: ./airlock_processor/Dockerfile
Expand All @@ -206,7 +206,7 @@ jobs:

- name: "Check pytest failure file existence"
id: check_airlock_processor_test_result
uses: andstor/file-existence-action@v2
uses: andstor/file-existence-action@v3
with:
files: "test-results/pytest_airlock_processor_unit_failed"

Expand All @@ -215,7 +215,7 @@ jobs:
(steps.filter.outputs.airlock_processor == 'true'
|| github.event_name == 'workflow_dispatch')
&& steps.check_airlock_processor_test_result.outputs.files_exists == 'false'
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: ./airlock_processor/
file: ./airlock_processor/Dockerfile
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
types: [published]
push:
paths:
- 'docs/**'
- "docs/**"
- mkdocs.yml
branches:
- main
Expand All @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout main
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: true
Expand All @@ -27,7 +27,7 @@ jobs:
run: |
pip install -r docs/requirements.txt
- name: Configure Git User
# Required by mike for the commit it does to the gh-pages branch
# Required by mike for the commit it does to the gh-pages branch
run: |
git config user.name "ci-docs"
git config user.email "[email protected]"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_validation_develop.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
name: Build Validation

on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
pull_request:
branches:
- main
- 'feature/**'
- "feature/**"

# for each ref (branch/pr) run just the most recent,
# cancel other pending/running ones
Expand All @@ -19,14 +19,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Full git history is needed to get a proper list of
# changed files within `super-linter`
fetch-depth: 0
persist-credentials: false

- uses: dorny/paths-filter@v2
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/clean_validation_envs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Clean Validation Environments

on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
schedule:
# Every 2 hours
- cron: "0 */2 * * *"
Expand All @@ -14,14 +14,14 @@ jobs:
environment: CICD
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# This is CRITICAL since we're making decisions based on branch existence
fetch-depth: 0
persist-credentials: false

- name: Azure Login
uses: azure/login@v1
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
environment: ${{ (secrets.AZURE_ENVIRONMENT != '' && secrets.AZURE_ENVIRONMENT) || 'AzureCloud' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cli-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

steps:
- name: Checkout (GitHub)
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build and run dev container task
uses: ./.github/actions/devcontainer_run_command
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/deploy_tre_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ jobs:
details_url: "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand All @@ -196,7 +196,7 @@ jobs:
uses: docker/setup-buildx-action@v2

- name: Azure Login
uses: azure/login@v1
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
environment: ${{ (vars.AZURE_ENVIRONMENT != '' && vars.AZURE_ENVIRONMENT) || 'AzureCloud' }}
Expand Down Expand Up @@ -274,7 +274,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand All @@ -298,7 +298,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand All @@ -322,7 +322,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -408,7 +408,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -454,7 +454,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -500,7 +500,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -560,7 +560,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -609,7 +609,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -643,7 +643,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -692,7 +692,7 @@ jobs:
environment: ${{ inputs.environmentName }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -723,7 +723,7 @@ jobs:
timeout-minutes: 10
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down Expand Up @@ -766,7 +766,7 @@ jobs:
timeout-minutes: 300
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/flag_external_pr.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flag_external_pr

on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
pull_request_target:
types: [opened] # only run on new PRs
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment
Expand All @@ -15,13 +15,13 @@ jobs:
steps:
# Ensure we have the script file for the github-script action to use
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false

- id: check_command
name: Check for a command using GitHub script
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
result-encoding: string
script: |
Expand Down
Loading
Loading