Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TLS to the latest version for web apps / function apps #4373

Merged

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Feb 13, 2025

Resolves #4351

What is being addressed

Sets the minimum TLS version to 1.3 for the following core web and function apps:

Core:

  • resource "azurerm_linux_web_app" "api" (core)
  • resource "azurerm_linux_function_app" "airlock_function_app" (core, airlock)

Templates:

  • resource "azurerm_linux_web_app" "guacamole"
  • resource "azurerm_linux_web_app" "gitea" (shared service)
  • resource "azurerm_linux_web_app" "gitea" (workspace service)
  • resource "azurerm_linux_web_app" "atlas_ui" (OHDSI)
  • resource "azurerm_linux_web_app" "ohdsi_webapi" (OHDSI)

@jonnyry jonnyry requested a review from marrobi February 13, 2025 21:18
Copy link

github-actions bot commented Feb 13, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8a1ee7f.

♻️ This comment has been updated with latest results.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 13, 2025

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13318118448 (with refid d4294c64)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 14, 2025

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13319463001 (with refid d4294c64)

(in response to this comment from @jonnyry)

@marrobi
Copy link
Member

marrobi commented Feb 14, 2025

@jonnyry any reason can't do the other web apps in the same PR? Guacamole, Gitea (x2)? Thanks.

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 14, 2025

@jonnyry any reason can't do the other web apps in the same PR? Guacamole, Gitea (x2)? Thanks.

Was running into AzureRM upgrade issues, but sorted now and checked in.

@jonnyry jonnyry changed the title Update TLS to the latest version for core web apps / function apps Update TLS to the latest version for web apps / function apps Feb 14, 2025
@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 14, 2025

/test 8a1ee7f

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13326072855 (with refid d4294c64)

(in response to this comment from @jonnyry)

@marrobi marrobi requested a review from LizaShak February 17, 2025 09:50
Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi merged commit d39b841 into microsoft:main Feb 17, 2025
12 checks passed
@jonnyry jonnyry deleted the jr/upstream-main/116-app-service-tls13-core branch February 17, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defender: TLS should be updated to the latest version for web apps / function apps
3 participants