Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TLS to the latest version for web apps / function apps #4373

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ENHANCEMENTS:
* Azure Cosmos DB should disable public network access ([#4322](https://github.com/microsoft/AzureTRE/issues/4322))
* Add bundle target to Makefile for handling different bundle types in single command ([#4372](https://github.com/microsoft/AzureTRE/issues/4372))
* Add Windows image field to the Admin VM template ([#4274](https://github.com/microsoft/AzureTRE/pull/4274))
* Update TLS to the latest version for web apps / function apps (([#4351](https://github.com/microsoft/AzureTRE/issues/4351))

BUG FIXES:
* Fix upgrade when porter install has failed ([#4338](https://github.com/microsoft/AzureTRE/pull/4338))
Expand Down
1 change: 1 addition & 0 deletions core/terraform/airlock/airlock_processor.tf
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ resource "azurerm_linux_function_app" "airlock_function_app" {
container_registry_use_managed_identity = true
vnet_route_all_enabled = true
ftps_state = "Disabled"
minimum_tls_version = "1.3"

application_stack {
docker {
Expand Down
2 changes: 1 addition & 1 deletion core/terraform/airlock/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">= 3.117"
version = ">= 4.14.0"
}
azapi = {
source = "Azure/azapi"
Expand Down
2 changes: 1 addition & 1 deletion core/terraform/api-webapp.tf
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ resource "azurerm_linux_web_app" "api" {
vnet_route_all_enabled = true
container_registry_use_managed_identity = true
container_registry_managed_identity_client_id = azurerm_user_assigned_identity.id.client_id
minimum_tls_version = "1.2"
minimum_tls_version = "1.3"
ftps_state = "Disabled"

application_stack {
Expand Down
2 changes: 1 addition & 1 deletion core/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.12.2"
__version__ = "0.12.3"
2 changes: 1 addition & 1 deletion templates/shared_services/gitea/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-shared-service-gitea
version: 1.1.4
version: 1.1.5
description: "A Gitea shared service"
dockerfile: Dockerfile.tmpl
registry: azuretre
Expand Down
28 changes: 14 additions & 14 deletions templates/shared_services/gitea/terraform/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 8 additions & 5 deletions templates/shared_services/gitea/terraform/gitea-webapp.tf
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ resource "azurerm_linux_web_app" "gitea" {
container_registry_managed_identity_client_id = azurerm_user_assigned_identity.gitea_id.client_id
ftps_state = "Disabled"
always_on = true
minimum_tls_version = "1.2"
minimum_tls_version = "1.3"
vnet_route_all_enabled = true

application_stack {
Expand Down Expand Up @@ -129,11 +129,14 @@ resource "azurerm_monitor_diagnostic_setting" "webapp_gitea" {
target_resource_id = azurerm_linux_web_app.gitea.id
log_analytics_workspace_id = data.azurerm_log_analytics_workspace.tre.id

dynamic "log" {
for_each = data.azurerm_monitor_diagnostic_categories.webapp.log_category_types
dynamic "enabled_log" {
for_each = [
for category in data.azurerm_monitor_diagnostic_categories.webapp.log_category_types :
category if contains(local.webapp_diagnostic_categories_enabled, category)
]
content {
category = log.value
enabled = contains(local.webapp_diagnostic_categories_enabled, log.value) ? true : false
category = enabled_log.value

}
}

Expand Down
2 changes: 1 addition & 1 deletion templates/shared_services/gitea/terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "=3.117.0"
version = "=4.14.0"
}
local = {
source = "hashicorp/local"
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/gitea/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-workspace-service-gitea
version: 1.2.2
version: 1.2.3
description: "A Gitea workspace service"
dockerfile: Dockerfile.tmpl
registry: azuretre
Expand Down
28 changes: 14 additions & 14 deletions templates/workspace_services/gitea/terraform/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions templates/workspace_services/gitea/terraform/gitea-webapp.tf
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ resource "azurerm_linux_web_app" "gitea" {
container_registry_managed_identity_client_id = azurerm_user_assigned_identity.gitea_id.client_id
ftps_state = "Disabled"
always_on = true
minimum_tls_version = "1.2"
minimum_tls_version = "1.3"
vnet_route_all_enabled = true

application_stack {
Expand Down Expand Up @@ -138,11 +138,13 @@ resource "azurerm_monitor_diagnostic_setting" "gitea" {
target_resource_id = azurerm_linux_web_app.gitea.id
log_analytics_workspace_id = data.azurerm_log_analytics_workspace.tre.id

dynamic "log" {
for_each = data.azurerm_monitor_diagnostic_categories.gitea.log_category_types
dynamic "enabled_log" {
for_each = [
for category in data.azurerm_monitor_diagnostic_categories.gitea.log_category_types :
category if contains(local.web_app_diagnostic_categories_enabled, category)
]
content {
category = log.value
enabled = contains(local.web_app_diagnostic_categories_enabled, log.value) ? true : false
category = enabled_log.value
}
}

Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/gitea/terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "=3.117.0"
version = "=4.14.0"
}
random = {
source = "hashicorp/random"
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/guacamole/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-service-guacamole
version: 0.12.7
version: 0.12.8
description: "An Azure TRE service for Guacamole"
dockerfile: Dockerfile.tmpl
registry: azuretre
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "=3.117.0"
version = "=4.14.0"
}
local = {
source = "hashicorp/local"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ resource "azurerm_linux_web_app" "guacamole" {
container_registry_managed_identity_client_id = azurerm_user_assigned_identity.guacamole_id.client_id
ftps_state = "Disabled"
vnet_route_all_enabled = true
minimum_tls_version = "1.2"
minimum_tls_version = "1.3"

application_stack {
docker_registry_url = "https://${data.azurerm_container_registry.mgmt_acr.login_server}"
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/ohdsi/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-workspace-service-ohdsi
version: 0.3.2
version: 0.3.3
description: "An OHDSI workspace service"
registry: azuretre
dockerfile: Dockerfile.tmpl
Expand Down
28 changes: 14 additions & 14 deletions templates/workspace_services/ohdsi/terraform/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions templates/workspace_services/ohdsi/terraform/atlas_ui.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ resource "azurerm_linux_web_app" "atlas_ui" {
client_affinity_enabled = false

site_config {
always_on = false
ftps_state = "Disabled"
always_on = false
ftps_state = "Disabled"
minimum_tls_version = "1.3"

application_stack {
docker_image = "index.docker.io/${local.atlas_ui_docker_image_name}"
docker_image_tag = local.atlas_ui_docker_image_tag
docker_image_name = "index.docker.io/${local.atlas_ui_docker_image_name}:${local.atlas_ui_docker_image_tag}"
}
}

Expand Down
8 changes: 4 additions & 4 deletions templates/workspace_services/ohdsi/terraform/ohdsi_web_api.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ resource "azurerm_linux_web_app" "ohdsi_webapi" {
client_affinity_enabled = false

site_config {
always_on = true
ftps_state = "Disabled"
always_on = true
ftps_state = "Disabled"
minimum_tls_version = "1.3"

application_stack {
docker_image = "index.docker.io/${local.ohdsi_api_docker_image_name}"
docker_image_tag = local.ohdsi_api_docker_image_tag
docker_image_name = "index.docker.io/${local.ohdsi_api_docker_image_name}:${local.ohdsi_api_docker_image_tag}"
}
}

Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/ohdsi/terraform/providers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "=3.117.0"
version = "=4.14.0"
}
local = {
source = "hashicorp/local"
Expand Down
Loading