Skip to content

Fix for missing default settings at startup. #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bschnurr merged 4 commits into from
Aug 14, 2025
Merged

Fix for missing default settings at startup. #8172

bschnurr merged 4 commits into from
Aug 14, 2025

Conversation

@bschnurr
Copy link
Member

@bschnurr bschnurr commented Feb 14, 2025 •
edited
Loading

guard against no context elements on shutdown. A context is created for the project or for each workspace or for each repl.

We need to send tasklist info when sending default settings with "workspace/didChangeConfiguration".

alternatively we could pass in the uri into GetSettings() when "TriggerWorkspaceUpdateConfig" is called.

Fix for #8121

@bschnurr bschnurr requested a review from a team as a code owner February 14, 2025 21:25
rchiodo
rchiodo reviewed Feb 14, 2025
View reviewed changes
Python/Product/PythonTools/PythonTools/LanguageServerClient/PythonLanguageClient.cs Outdated
if (context == null) {
return null;
// use first clientcontext as default
context = _clientContexts.First();
Copy link
Contributor

@rchiodo rchiodo Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a FirstOrNull thing? I wasn't sure if this would throw if there's no items in the list.

Copy link
Contributor

@rchiodo rchiodo Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it's called 'FirstOrDefault'. Maybe you should use that?

Copy link
Member Author

@bschnurr bschnurr Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i check count at the top of the function. but ya. that would be safer

debonte
debonte previously approved these changes Feb 14, 2025
View reviewed changes
rchiodo
rchiodo previously approved these changes Feb 14, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bschnurr
Copy link
Member Author

bschnurr commented Feb 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bschnurr bschnurr dismissed stale reviews from rchiodo and debonte via adb386e March 31, 2025 22:20
@bschnurr bschnurr closed this May 23, 2025
@bschnurr bschnurr reopened this May 23, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bschnurr bschnurr closed this Aug 13, 2025
@bschnurr bschnurr reopened this Aug 13, 2025
@bschnurr
Copy link
Member Author

bschnurr commented Aug 13, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bschnurr bschnurr closed this Aug 13, 2025
@bschnurr bschnurr reopened this Aug 13, 2025
@bschnurr
Copy link
Member Author

bschnurr commented Aug 13, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bschnurr
Fix for missing default settings at startup.
66e3cf7 
guard against no context elements on shutdown.  A context is created for the project or for each workspace or for each repl.
@bschnurr
adding try/catch
54b2140
@bschnurr
use FirstOrDefault
ebb8aa0
@bschnurr
fix race condition where repl context has no InterpreterConfiguration…
db8ae5e 
… set yet.
@bschnurr bschnurr closed this Aug 13, 2025
@bschnurr bschnurr reopened this Aug 13, 2025
@bschnurr
Copy link
Member Author

bschnurr commented Aug 13, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bschnurr bschnurr merged commit 6e44e4e into microsoft:main Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@StellaHuang95 StellaHuang95 StellaHuang95 approved these changes

+1 more reviewer

@debonte debonte debonte left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bschnurr @debonte @rchiodo @StellaHuang95