Skip to content

Fix for missing default settings at startup. #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bschnurr merged 4 commits into from
Aug 14, 2025
Merged

Fix for missing default settings at startup. #8172

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66e3cf7
Fix for missing default settings at startup.
bschnurr Feb 14, 2025
54b2140
adding try/catch
bschnurr Feb 14, 2025
ebb8aa0
use FirstOrDefault
bschnurr May 26, 2025
db8ae5e
fix race condition where repl context has no InterpreterConfiguration…
bschnurr Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Python/Product/PythonTools/PythonTools/LanguageServerClient/PythonLanguageClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,20 +367,30 @@ private async Task NotifyWithParametersAsync(string request, object parameters)
}

private LanguageServerSettings.PythonSettings GetSettings(Uri scopeUri = null) {
// guard on shutdown
if (_clientContexts.Count() == 0) {
return null;
}
IPythonLanguageClientContext context = null;
if (scopeUri == null) {
// REPL context has null RootPath
// REPL context has null RootPath
context = _clientContexts.Find(c => c.RootPath == null);
if (context == null) {
return null;
// use first clientcontext as default
try {
context = _clientContexts.FirstOrDefault();
} catch (InvalidOperationException) {
// no client context
return null;
}
}
} else {
var pathFromScopeUri = CommonUtils.NormalizeDirectoryPath(scopeUri.LocalPath).ToLower().TrimStart('\\');
// Find the matching context for the item, but ignore interactive window where "RootPath" is null.
context = _clientContexts.Find(c => scopeUri != null && c.RootPath != null && PathUtils.IsSamePath(c.RootPath.ToLower(), pathFromScopeUri));
}

if (context == null) {
if (context == null || context.InterpreterConfiguration == null) {
Debug.WriteLine(String.Format("GetSettings() scopeUri not found: {0}", scopeUri));
return null;
}
Expand Down