[ZoomIt] Show users full hotkey list in settings by vanzue · Pull Request #43073 · microsoft/PowerToys

vanzue · 2025-10-29T13:13:45Z

Summary of the Pull Request

This PR enhances the ZoomIt settings UI by refactoring some of the XAML code and putting instructions as part of the settingsexpanders. Additionally, the alternate hotkey combinations are now shown too and will be updated based on the configured hotkey.
so that Users will now be able to see all the hotkeys.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

ZoomIt Extended (Derived) Hotkeys

Feature	Base Key Property	Default Base Key	Derived Key Property	XOR Logic	Default Derived Key	Description
LiveZoom	LiveZoomToggleKey	Ctrl+4	LiveZoomToggleKeyDraw	XOR Shift	Ctrl+Shift+4	Enter drawing mode in LiveZoom
Record	RecordToggleKey	Ctrl+5	RecordToggleKeyCrop	XOR Shift	Ctrl+Shift+5	Record selected region (crop)
Record	RecordToggleKey	Ctrl+5	RecordToggleKeyWindow	XOR Alt	Ctrl+Alt+5	Record specific window
Snip	SnipToggleKey	Ctrl+6	SnipToggleKeySave	XOR Shift	Ctrl+Shift+6	Snip and save to file
DemoType	DemoTypeToggleKey	Ctrl+7	DemoTypeToggleKeyReset	XOR Shift	Ctrl+Shift+7	Rewind to previous segment

vanzue · 2025-10-30T04:00:57Z

/azp run

azure-pipelines · 2025-10-30T04:01:06Z

Azure Pipelines successfully started running 1 pipeline(s).

niels9001 · 2025-12-05T11:11:55Z

/azp run

azure-pipelines · 2025-12-05T11:12:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Jay-o-Way

Got a screenshot? Worried about all the formatting...

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

niels9001 · 2025-12-08T08:24:33Z

/azp run

azure-pipelines · 2025-12-08T08:24:42Z

Azure Pipelines successfully started running 1 pipeline(s).

check-spelling run (pull_request_target) for dev/vanzue/zoomit-hotkey Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev>

Jay-o-Way

Please add screenshots to the main pr message. Notice how the code formatting messes up parts like Ctrl '' C? Please adjust to what I suggested.

Jay-o-Way

No-go

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

src/settings-ui/Settings.UI/ViewModels/ZoomItViewModel.cs

niels9001 · 2025-12-18T11:12:10Z

@Jay-o-Way Great feedback! I've pushed some improvements, see the original post for a screenshot.

Looking at Windows 11 Settings, there doesn't seem to be a clear standard of how to visualize shortcut instructions. I'm sticking to 12pt / TextFillColorSecondaryBrush for now, and bold for the shortcut.

Nit: should be SemiBold ideally, but we can't change the default FontWeight for MarkdownTextBlock - something I'll address in: CommunityToolkit/Labs-Windows#761 and add it as a property so we can override it in the future.

Jay-o-Way · 2025-12-18T11:18:20Z

Idea: the Footer of the Settings expander is often overlooked. Would it be good to place te (explanatory) text in there?

niels9001 · 2025-12-18T13:10:28Z

Idea: the Footer of the Settings expander is often overlooked. Would it be good to place te (explanatory) text in there?

There wouldn't be a visible difference, and we need the Name on the SettingsCard to ensure that Search works. Adding a SettingsCard in the ItemsFooter would require additional XAML overrides to ensure it renders properly.

…ft/PowerToys into dev/vanzue/zoomit-hotkey

Jay-o-Way · 2025-12-25T13:13:52Z

src/settings-ui/Settings.UI/SettingsXAML/Views/ZoomItPage.xaml

-                                    <RadioButton x:Uid="ZoomIt_Break_ShowImageFile" />
-                                </RadioButtons>
+                            <tkcontrols:SettingsCard Name="ZoomItBreakTimerOpacity" x:Uid="ZoomIt_Break_TimerOpacity">
+                                <ComboBox MinWidth="{StaticResource SettingActionControlMinWidth}" SelectedIndex="{x:Bind Path=ViewModel.BreakTimerOpacityIndex, Mode=TwoWay}">


~~I think~~ this should be a Slider.

Changed to a slider, and made sure that the zoomit support any int from 1 ~ 100, no need to bind 10 as a step

Jay-o-Way · 2025-12-25T13:14:55Z

src/settings-ui/Settings.UI/SettingsXAML/Views/ZoomItPage.xaml

+                                </ComboBox>
+                            </tkcontrols:SettingsCard>
+                            <tkcontrols:SettingsCard Name="ZoomItBreakTimerPosition" x:Uid="ZoomIt_Break_TimerPosition">
+                                <ComboBox MinWidth="{StaticResource SettingActionControlMinWidth}" SelectedIndex="{x:Bind Path=ViewModel.BreakTimerPosition, Mode=TwoWay}">


I believe the MinWidth property is built-in (right, @niels9001 ?)

src/settings-ui/Settings.UI/SettingsXAML/Views/ZoomItPage.xaml

Jay-o-Way · 2025-12-25T13:16:21Z

src/settings-ui/Settings.UI/SettingsXAML/Views/ZoomItPage.xaml

-                    </tkcontrols:SettingsCard>
+                        <tkcontrols:SettingsExpander.Items>
+                            <tkcontrols:SettingsCard Name="ZoomItRecordScaling" x:Uid="ZoomIt_Record_Scaling">
+                                <ComboBox MinWidth="{StaticResource SettingActionControlMinWidth}" SelectedIndex="{x:Bind Path=ViewModel.RecordScalingIndex, Mode=TwoWay}">


Same: Slider.

Thanks!
I think the word "scaling" is too short and general to be clear for a first time user. Also, how to choose between a factor and a percentage?

Should addressed all

Jay-o-Way · 2026-01-27T11:09:38Z

@niels9001 I have an issue with the words in the descriptions. Microsoft says to use "select" in stead of "press", and why would you choose "press mouse button" when you can simply say "click" or "right-click"? Specific: "press the mouse wheel"?? 😐

vanzue · 2026-01-28T02:20:27Z

I think Jay raised really good concern/topic, so I raised another issue, to keep this one focused on displaying all the hotkeys so users can know what they can do with zoomit, and to reduce the uncertainty of key binding, but we can have more discussion here:
#45132

## Summary of the Pull Request This PR enhances the ZoomIt settings UI by refactoring some of the XAML code and putting instructions as part of the settingsexpanders. Additionally, the alternate hotkey combinations are now shown too and will be updated based on the configured hotkey. so that **Users will now be able to see all the hotkeys**.  ## PR Checklist - [x] Closes: #42236 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx  ## Detailed Description of the Pull Request / Additional comments  ## Validation Steps Performed ### ZoomIt Extended (Derived) Hotkeys Feature | Base Key Property | Default Base Key | Derived Key Property | XOR Logic | Default Derived Key | Description -- | -- | -- | -- | -- | -- | -- LiveZoom | LiveZoomToggleKey | Ctrl+4 | LiveZoomToggleKeyDraw | XOR Shift | Ctrl+Shift+4 | Enter drawing mode in LiveZoom Record | RecordToggleKey | Ctrl+5 | RecordToggleKeyCrop | XOR Shift | Ctrl+Shift+5 | Record selected region (crop) Record | RecordToggleKey | Ctrl+5 | RecordToggleKeyWindow | XOR Alt | Ctrl+Alt+5 | Record specific window Snip | SnipToggleKey | Ctrl+6 | SnipToggleKeySave | XOR Shift | Ctrl+Shift+6 | Snip and save to file DemoType | DemoTypeToggleKey | Ctrl+7 | DemoTypeToggleKeyReset | XOR Shift | Ctrl+Shift+7 | Rewind to previous segment <img width="832" height="3679" alt="Frame 2018778631" src="https://github.com/user-attachments/assets/bebddcd8-d705-4582-ae8a-c847cb1c3e88" /> --------- Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> Co-authored-by: Niels Laute <niels.laute@live.nl> Co-authored-by: Kai Tao <vanzue@users.noreply.github.com>

vanzue added 2 commits October 29, 2025 14:17

zoomit hotkey

5938231

other functionality has hotkey binding magic too

380e4c6

vanzue and others added 2 commits October 30, 2025 14:44

format xaml

1006e73

Merge remote-tracking branch 'origin/main' into dev/vanzue/zoomit-hotkey

455bc55

vanzue added the Product-ZoomIt Refers to the ZoomIt tool label Nov 4, 2025

Merge remote-tracking branch 'origin/main' into dev/vanzue/zoomit-hotkey

863db5a

This comment has been minimized.

Sign in to view

niels9001 and others added 3 commits December 2, 2025 17:15

ZoomIt UX refactor

c0d9f53

Merge remote-tracking branch 'origin/main' into dev/vanzue/zoomit-hotkey

1d022dc

use combo box instead of radio button group for break mode background

a4da3f1

niels9001 changed the title ~~Zoomit: Show all the hotkey registered for Zoomt~~ [ZoomIt] Settings UX improvements Dec 3, 2025

Jay-o-Way reviewed Dec 7, 2025

View reviewed changes

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Outdated Show resolved Hide resolved

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Outdated Show resolved Hide resolved

niels9001 added the In for .97 label Dec 8, 2025

merge main

b618570

This comment has been minimized.

Sign in to view

vanzue and others added 2 commits December 18, 2025 14:03

Update metadata

75d0ad6

check-spelling run (pull_request_target) for dev/vanzue/zoomit-hotkey Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev>

fix build failure

2dfa6b9

Jay-o-Way suggested changes Dec 18, 2025

View reviewed changes

Jay-o-Way previously requested changes Dec 18, 2025

View reviewed changes

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Outdated Show resolved Hide resolved

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Outdated Show resolved Hide resolved

src/settings-ui/Settings.UI/ViewModels/ZoomItViewModel.cs Outdated Show resolved Hide resolved

fix a comment

25e756a

niels9001 requested a review from Jay-o-Way December 18, 2025 13:10

niels9001 added 2 commits December 18, 2025 14:10

Updates

8ceea3b

Merge branch 'dev/vanzue/zoomit-hotkey' of https://github.com/microso…

188ea02

…ft/PowerToys into dev/vanzue/zoomit-hotkey

Jay-o-Way reviewed Dec 25, 2025

View reviewed changes

src/settings-ui/Settings.UI/SettingsXAML/Views/ZoomItPage.xaml Outdated Show resolved Hide resolved

Jay-o-Way reviewed Dec 25, 2025

View reviewed changes

niels9001 added In for .98 and removed In for .97 labels Jan 8, 2026

vanzue mentioned this pull request Jan 26, 2026

zoom it 을 on 하면 ctrl+f 할때 펜그리기가 바로 활성화 됩니다 문서 찾기할때 중복이 됩니다 #45036

Open

vanzue added 3 commits January 26, 2026 15:12

fix conflict

41be6fa

fix a xml break

4cc3b13

fix comments

0cf3803

vanzue requested a review from Jay-o-Way January 27, 2026 08:14

vanzue mentioned this pull request Jan 28, 2026

Standardize mouse/keyboard interaction wording across Settings descriptions #45132

Open

vanzue changed the title ~~[ZoomIt] Settings UX improvements~~ [ZoomIt] Show users full hotkey list in settings Jan 28, 2026

shuaiyuanxx approved these changes Jan 28, 2026

View reviewed changes

vanzue merged commit f534e5b into main Jan 28, 2026
15 checks passed

vanzue deleted the dev/vanzue/zoomit-hotkey branch January 28, 2026 02:37

Conversation

vanzue commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

ZoomIt Extended (Derived) Hotkeys

Uh oh!

vanzue commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

This comment has been minimized.

niels9001 commented Dec 5, 2025

Uh oh!

azure-pipelines bot commented Dec 5, 2025

Uh oh!

Jay-o-Way left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

niels9001 commented Dec 8, 2025

Uh oh!

azure-pipelines bot commented Dec 8, 2025

Uh oh!

This comment has been minimized.

Jay-o-Way left a comment

Choose a reason for hiding this comment

Uh oh!

Jay-o-Way left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niels9001 commented Dec 18, 2025

Uh oh!

Jay-o-Way commented Dec 18, 2025

Uh oh!

niels9001 commented Dec 18, 2025

Uh oh!

Jay-o-Way Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vanzue Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

vanzue Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Jay-o-Way Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jay-o-Way Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vanzue Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Jay-o-Way Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Jay-o-Way Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Jay-o-Way commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vanzue commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

vanzue commented Oct 29, 2025 •

edited

Loading

Jay-o-Way Dec 25, 2025 •

edited

Loading

Jay-o-Way Dec 25, 2025 •

edited

Loading

Jay-o-Way commented Jan 27, 2026 •

edited

Loading