Pipeline Performance Optimization: Make Static Analysis Run Parallelly with Build

build/AzurePipelinesTemplates/WindowsAppSDK-Build-Per-Platform-Stage.yml

@@ -0,0 +1,168 @@
+parameters:
+- name: "SignOutput"
+  type: boolean
+  default: false
+- name: "IsOneBranch"
+  type: boolean
+  default: true
+- name: runStaticAnalysis
+  type: boolean
+  default: true
+- name: buildPlatform
+  type: string
+  default: x64
+
+stages:
+- stage: ${{ format(iif(parameters.runStaticAnalysis, 'Build_{0}_StaticAnalysis', 'Build_{0}'), parameters.buildPlatform) }}
+  # Skip the build job if we are reusing the output of a previous build.
+  # useBuildOutputFromBuildId variable is set on the Pipeline at Queue time.
+  condition:
+    eq(variables['useBuildOutputFromBuildId'],'')
+  dependsOn: []
+  jobs:
+  - job: BuildFoundation
+    pool:
+      ${{ if parameters.IsOneBranch }}:
+        type: windows
+      ${{ if not( parameters.IsOneBranch ) }}:
+        type: windows
+        isCustom: true
+        name: 'ProjectReunionESPool-2022'
+    timeoutInMinutes: 120
+    strategy:
+      maxParallel: 10
+      matrix:
+        ${{ format('Release_{0}', parameters.buildPlatform) }}:
+          ${{ if ne(parameters.buildPlatform, 'arm64') }}:
+            buildPlatform: ${{ parameters.buildPlatform }}
+            buildConfiguration: 'release'
+            normalizedConfiguration: 'fre'
+            PGOBuildMode: 'Optimize'
+          ${{ else }}:
+            buildPlatform: ${{ parameters.buildPlatform }}
+            buildConfiguration: 'release'
+            normalizedConfiguration: 'fre'
+    variables:
+      - name: ob_outputDirectory
+        value: '$(REPOROOT)\out'
+      - name: ob_sdl_codeSignValidation_excludes
+        value: '-|**\Release\**;-|**\packages\**'
+      - name: ob_artifactBaseName
+        value: "FoundationBinaries_$(buildConfiguration)_$(buildPlatform)"
+      - name: ob_sdl_apiscan_enabled
+        ${{ if parameters.runStaticAnalysis }}:
+          value: true
+        ${{ else }}:
+          value: false
+      - name: ob_sdl_apiscan_softwareFolder
+        value: '$(build.SourcesDirectory)\APIScanTarget'
+      - name: ob_sdl_apiscan_symbolsFolder
+        value: '$(build.SourcesDirectory)\APIScanTarget;SRV*https://symweb.azurefd.net'
+      - template: AzurePipelinesTemplates/WindowsAppSDK-Global-LKGVersions.yml@WindowsAppSDKConfigSourceBranch
+      - name: localCompilerOverridePackageName
+        value: $[coalesce(variables.compilerOverridePackageName, variables.global_CompilerOverridePackageName)]
+      - name: localCompilerOverridePackageVersion
+        value: $[coalesce(variables.compilerOverridePackageVersion, variables.global_CompilerOverridePackageVersion)]
+      - name: localCompilerOverrideNupkgVersion
+        value: $[coalesce(variables.compilerOverrideNupkgVersion, variables.global_CompilerOverrideNupkgVersion)]    
+    steps:
+    - script: |
+        echo Build.SourceBranch=$(Build.SourceBranch)
+        echo Build.Reason=$(Build.Reason)
+        echo compilerOverridePackageName=$(compilerOverridePackageName)
+        echo compilerOverridePackageVersion=$(compilerOverridePackageVersion)
+        echo global_CompilerOverridePackageName=$(global_CompilerOverridePackageName)
+        echo global_CompilerOverridePackageVersion=$(global_CompilerOverridePackageVersion)
+        echo localCompilerOverridePackageName=$(localCompilerOverridePackageName)
+        echo localCompilerOverridePackageVersion=$(localCompilerOverridePackageVersion)
+        echo localCompilerOverrideNupkgVersion=$(localCompilerOverrideNupkgVersion)
+        echo System.PullRequest.targetBranchName=$(System.PullRequest.targetBranchName)
+        echo mySourceBranch=$(mySourceBranch)        
+
+    - template: WindowsAppSDK-BuildFoundation-Steps.yml@self
+      parameters:
+        SignOutput: ${{ parameters.SignOutput }}
+        IsOneBranch: ${{ parameters.IsOneBranch }}
+        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+
+    # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
+    # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-
+    # requisite of isNative=true isn't met currently.
+    - script: |
+        md "C:\__t\NativeCompilerPrefast"
+      displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'
+
+  - job: BuildMRT
+    pool:
+      # read more about custom job pool types at https://aka.ms/obpipelines/yaml/jobs
+      ${{ if parameters.IsOneBranch }}:
+        type: windows
+      ${{ if not( parameters.IsOneBranch ) }}:
+        type: windows
+        isCustom: true
+        name: 'ProjectReunionESPool-2022'
+    timeoutInMinutes: 120
+    strategy:
+      maxParallel: 10
+      matrix:
+        ${{ format('Release_{0}', parameters.buildPlatform) }}:
+          ${{ if ne(parameters.buildPlatform, 'arm64') }}:
+            buildPlatform: ${{ parameters.buildPlatform }}
+            buildConfiguration: 'Release'
+            normalizedConfiguration: 'fre'
+            PGOBuildMode: 'Optimize'
+          ${{ else }}:
+            buildPlatform: ${{ parameters.buildPlatform }}
+            buildConfiguration: 'Release'
+            normalizedConfiguration: 'fre'
+    variables:
+      - name: ob_outputDirectory
+        value: '$(REPOROOT)\out'
+      - name: ob_sdl_codeSignValidation_excludes
+        value: '-|**\Release\**'
+      - name: ob_sdl_suppression_suppressionSet
+        value: default
+      - name: ob_artifactBaseName
+        value: "MrtBinaries_$(buildConfiguration)_$(buildPlatform)"
+      - name: ob_sdl_apiscan_enabled
+        ${{ if parameters.runStaticAnalysis }}:
+          value: true
+        ${{ else }}:
+          value: false
+      - name: ob_sdl_apiscan_softwareFolder
+        value: '$(build.SourcesDirectory)\APIScanTarget'
+      - name: ob_sdl_apiscan_symbolsFolder
+        value: '$(build.SourcesDirectory)\APIScanTarget;SRV*https://symweb.azurefd.net'
+      - template: AzurePipelinesTemplates/WindowsAppSDK-Global-LKGVersions.yml@WindowsAppSDKConfigSourceBranch
+      - name: localCompilerOverridePackageName
+        value: $[coalesce(variables.compilerOverridePackageName, variables.global_CompilerOverridePackageName)]
+      - name: localCompilerOverridePackageVersion
+        value: $[coalesce(variables.compilerOverridePackageVersion, variables.global_CompilerOverridePackageVersion)]
+      - name: localCompilerOverrideNupkgVersion
+        value: $[coalesce(variables.compilerOverrideNupkgVersion, variables.global_CompilerOverrideNupkgVersion)]    
+    steps:
+    - script: |
+        echo Build.SourceBranch=$(Build.SourceBranch)
+        echo Build.Reason=$(Build.Reason)
+        echo compilerOverridePackageName=$(compilerOverridePackageName)
+        echo compilerOverridePackageVersion=$(compilerOverridePackageVersion)
+        echo global_CompilerOverridePackageName=$(global_CompilerOverridePackageName)
+        echo global_CompilerOverridePackageVersion=$(global_CompilerOverridePackageVersion)
+        echo localCompilerOverridePackageName=$(localCompilerOverridePackageName)
+        echo localCompilerOverridePackageVersion=$(localCompilerOverridePackageVersion)
+        echo localCompilerOverrideNupkgVersion=$(localCompilerOverrideNupkgVersion)
+        echo System.PullRequest.targetBranchName=$(System.PullRequest.targetBranchName)
+        echo mySourceBranch=$(mySourceBranch)        
+
+    - template: WindowsAppSDK-BuildMRT-Steps.yml@self
+      parameters:
+        SignOutput: ${{ parameters.SignOutput }}
+        IsOneBranch: ${{ parameters.IsOneBranch }}
+        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+
+    # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
+    # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-
+    # requisite of isNative=true isn't met currently.
+    - script: |
+        md "C:\__t\NativeCompilerPrefast"
+      displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'

build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml

@@ -10,7 +10,7 @@ parameters:
   default: true
 
 stages:
-- stage: Build
+- stage: ${{ iif(parameters.runStaticAnalysis, 'Build_AnyCPU_StaticAnalysis', 'Build_AnyCPU') }}
   # Skip the build job if we are reusing the output of a previous build.
   # useBuildOutputFromBuildId variable is set on the Pipeline at Queue time.
   condition:
@@ -30,82 +30,6 @@ stages:
         targetType: filePath
         filePath: tools\VerifyCopyrightHeaders.ps1
 
-  - job: BuildFoundation
-    pool:
-      ${{ if parameters.IsOneBranch }}:
-        type: windows
-      ${{ if not( parameters.IsOneBranch ) }}:
-        type: windows
-        isCustom: true
-        name: 'ProjectReunionESPool-2022'
-    timeoutInMinutes: 120
-    strategy:
-      maxParallel: 10
-      matrix:
-        Release_x86:
-          buildPlatform: 'x86'
-          buildConfiguration: 'release'
-          normalizedConfiguration: 'fre'
-          PGOBuildMode: 'Optimize'
-        Release_x64:
-          buildPlatform: 'x64'
-          buildConfiguration: 'release'
-          normalizedConfiguration: 'fre'
-          PGOBuildMode: 'Optimize'
-        Release_Arm64:
-          buildPlatform: 'arm64'
-          buildConfiguration: 'release'
-          normalizedConfiguration: 'fre'
-    variables:
-      - name: ob_outputDirectory
-        value: '$(REPOROOT)\out'
-      - name: ob_sdl_codeSignValidation_excludes
-        value: '-|**\Release\**;-|**\packages\**'
-      - name: ob_artifactBaseName
-        value: "FoundationBinaries_$(buildConfiguration)_$(buildPlatform)"
-      - name: ob_sdl_apiscan_enabled
-        ${{ if parameters.runStaticAnalysis }}:
-          value: true
-        ${{ else }}:
-          value: false
-      - name: ob_sdl_apiscan_softwareFolder
-        value: '$(build.SourcesDirectory)\APIScanTarget'
-      - name: ob_sdl_apiscan_symbolsFolder
-        value: '$(build.SourcesDirectory)\APIScanTarget;SRV*https://symweb.azurefd.net'
-      - template: AzurePipelinesTemplates/WindowsAppSDK-Global-LKGVersions.yml@WindowsAppSDKConfigSourceBranch
-      - name: localCompilerOverridePackageName
-        value: $[coalesce(variables.compilerOverridePackageName, variables.global_CompilerOverridePackageName)]
-      - name: localCompilerOverridePackageVersion
-        value: $[coalesce(variables.compilerOverridePackageVersion, variables.global_CompilerOverridePackageVersion)]
-      - name: localCompilerOverrideNupkgVersion
-        value: $[coalesce(variables.compilerOverrideNupkgVersion, variables.global_CompilerOverrideNupkgVersion)]    
-    steps:
-    - script: |
-        echo Build.SourceBranch=$(Build.SourceBranch)
-        echo Build.Reason=$(Build.Reason)
-        echo compilerOverridePackageName=$(compilerOverridePackageName)
-        echo compilerOverridePackageVersion=$(compilerOverridePackageVersion)
-        echo global_CompilerOverridePackageName=$(global_CompilerOverridePackageName)
-        echo global_CompilerOverridePackageVersion=$(global_CompilerOverridePackageVersion)
-        echo localCompilerOverridePackageName=$(localCompilerOverridePackageName)
-        echo localCompilerOverridePackageVersion=$(localCompilerOverridePackageVersion)
-        echo localCompilerOverrideNupkgVersion=$(localCompilerOverrideNupkgVersion)
-        echo System.PullRequest.targetBranchName=$(System.PullRequest.targetBranchName)
-        echo mySourceBranch=$(mySourceBranch)        
-
-    - template: WindowsAppSDK-BuildFoundation-Steps.yml@self
-      parameters:
-        SignOutput: ${{ parameters.SignOutput }}
-        IsOneBranch: ${{ parameters.IsOneBranch }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
-
-    # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
-    # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-
-    # requisite of isNative=true isn't met currently.
-    - script: |
-        md "C:\__t\NativeCompilerPrefast"
-      displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'
-
   - job: BuildFoundation_release_anycpu
     # For now, this job just builds Microsoft.WindowsAppRuntime.Bootstrap.Net.dll in AnyCPU
     # Can be expanded to add any other binary as needed
@@ -140,81 +64,24 @@ stages:
         md "C:\__t\NativeCompilerPrefast"
       displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'
 
-  - job: BuildMRT
-    pool:
-      # read more about custom job pool types at https://aka.ms/obpipelines/yaml/jobs
-      ${{ if parameters.IsOneBranch }}:
-        type: windows
-      ${{ if not( parameters.IsOneBranch ) }}:
-        type: windows
-        isCustom: true
-        name: 'ProjectReunionESPool-2022'
-    timeoutInMinutes: 120
-    strategy:
-      maxParallel: 10
-      matrix:
-        Release_x86:
-          buildPlatform: 'x86'
-          buildConfiguration: 'Release'
-          normalizedConfiguration: 'fre'
-          PGOBuildMode: 'Optimize'
-        Release_x64:
-          buildPlatform: 'x64'
-          buildConfiguration: 'Release'
-          normalizedConfiguration: 'fre'
-          PGOBuildMode: 'Optimize'
-        Release_Arm64:
-          buildPlatform: 'arm64'
-          buildConfiguration: 'Release'
-          normalizedConfiguration: 'fre'
-    variables:
-      - name: ob_outputDirectory
-        value: '$(REPOROOT)\out'
-      - name: ob_sdl_codeSignValidation_excludes
-        value: '-|**\Release\**'
-      - name: ob_sdl_suppression_suppressionSet
-        value: default
-      - name: ob_artifactBaseName
-        value: "MrtBinaries_$(buildConfiguration)_$(buildPlatform)"
-      - name: ob_sdl_apiscan_enabled
-        ${{ if parameters.runStaticAnalysis }}:
-          value: true
-        ${{ else }}:
-          value: false
-      - name: ob_sdl_apiscan_softwareFolder
-        value: '$(build.SourcesDirectory)\APIScanTarget'
-      - name: ob_sdl_apiscan_symbolsFolder
-        value: '$(build.SourcesDirectory)\APIScanTarget;SRV*https://symweb.azurefd.net'
-      - template: AzurePipelinesTemplates/WindowsAppSDK-Global-LKGVersions.yml@WindowsAppSDKConfigSourceBranch
-      - name: localCompilerOverridePackageName
-        value: $[coalesce(variables.compilerOverridePackageName, variables.global_CompilerOverridePackageName)]
-      - name: localCompilerOverridePackageVersion
-        value: $[coalesce(variables.compilerOverridePackageVersion, variables.global_CompilerOverridePackageVersion)]
-      - name: localCompilerOverrideNupkgVersion
-        value: $[coalesce(variables.compilerOverrideNupkgVersion, variables.global_CompilerOverrideNupkgVersion)]    
-    steps:
-    - script: |
-        echo Build.SourceBranch=$(Build.SourceBranch)
-        echo Build.Reason=$(Build.Reason)
-        echo compilerOverridePackageName=$(compilerOverridePackageName)
-        echo compilerOverridePackageVersion=$(compilerOverridePackageVersion)
-        echo global_CompilerOverridePackageName=$(global_CompilerOverridePackageName)
-        echo global_CompilerOverridePackageVersion=$(global_CompilerOverridePackageVersion)
-        echo localCompilerOverridePackageName=$(localCompilerOverridePackageName)
-        echo localCompilerOverridePackageVersion=$(localCompilerOverridePackageVersion)
-        echo localCompilerOverrideNupkgVersion=$(localCompilerOverrideNupkgVersion)
-        echo System.PullRequest.targetBranchName=$(System.PullRequest.targetBranchName)
-        echo mySourceBranch=$(mySourceBranch)        
+# extract BuildFoundation and BuildMRT into WindowsAppSDK-Build-Stage-Per-Platform.yml. Separate the build stage per platform
+- template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
+  parameters:
+    SignOutput: ${{ parameters.SignOutput }}
+    IsOneBranch: ${{ parameters.IsOneBranch }}
+    runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+    BuildPlatform: x86
 
-    - template: WindowsAppSDK-BuildMRT-Steps.yml@self
-      parameters:
-        SignOutput: ${{ parameters.SignOutput }}
-        IsOneBranch: ${{ parameters.IsOneBranch }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+- template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
+  parameters:
+    SignOutput: ${{ parameters.SignOutput }}
+    IsOneBranch: ${{ parameters.IsOneBranch }}
+    runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+    BuildPlatform: x64
 
-    # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
-    # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-
-    # requisite of isNative=true isn't met currently.
-    - script: |
-        md "C:\__t\NativeCompilerPrefast"
-      displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'
+- template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
+  parameters:
+    SignOutput: ${{ parameters.SignOutput }}
+    IsOneBranch: ${{ parameters.IsOneBranch }}
+    runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+    BuildPlatform: arm64

build/AzurePipelinesTemplates/WindowsAppSDK-PackTransportPackage-Stage.yml

@@ -17,7 +17,11 @@ parameters:
 
 stages:
 - stage: Pack
-  dependsOn: Build
+  dependsOn: 
+    - Build_AnyCPU
+    - Build_x86
+    - Build_x64
+    - Build_arm64
   condition:
     eq(variables['useBuildOutputFromBuildId'],'')
   jobs:
@@ -202,4 +206,4 @@ stages:
           verbosityPush: 'Detailed'
           nuGetFeedType: 'internal'
           #Note: The project qualifier is always required when using a feed name. Also, do not use organization scoped feeds.
-          publishVstsFeed: 'ProjectReunion/Project.Reunion.nuget.internal'
+          publishVstsFeed: 'ProjectReunion/Project.Reunion.nuget.internal'