fix: centralize hardcoded ring thresholds and constants (#171)#188
Merged
imran-siddique merged 6 commits intomicrosoft:mainfrom Mar 12, 2026
Merged
fix: centralize hardcoded ring thresholds and constants (#171)#188imran-siddique merged 6 commits intomicrosoft:mainfrom
imran-siddique merged 6 commits intomicrosoft:mainfrom
Conversation
|
Welcome to the Agent Governance Toolkit! Thanks for your first pull request. |
github-actions
bot
added
tests
agent-hypervisor
…s.py Fixes microsoft#171 Ring thresholds and constants were hardcoded with duplicate values across multiple files (rate_limiter.py, enforcer.py, models.py, vouching.py, orchestrator.py). This commit introduces a single constants.py module under hypervisor/ and updates all source files to import from it. Constants centralized: - Ring trust-score thresholds (0.95, 0.70, 0.60) - Rate-limiter defaults per ring (req/s and burst capacity) - Vouching/sponsorship thresholds (score scale, bond pct, max exposure) - Saga orchestrator defaults (retries, delay, step timeout) - Validation limits (agent ID, name, API path, participants, duration) - Risk-weight ranges by reversibility level - Session default min_eff_score All 562 existing tests pass with zero failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Centralize hardcoded ring thresholds and constants into a single
hypervisor/constants.pymodule. Values were previously duplicated acrossrate_limiter.py,enforcer.py,models.py,vouching.py, andorchestrator.py.Type of Change
Package(s) Affected
Checklist
Related Issues
Fixes #171
Fixes #171