Fix build APPX packages on version 2021.X.X and higher #520
Open
aleksandr-dorofeev wants to merge 4 commits intodevelopfrom
Open
Fix build APPX packages on version 2021.X.X and higher #520aleksandr-dorofeev wants to merge 4 commits intodevelopfrom
aleksandr-dorofeev wants to merge 4 commits intodevelopfrom
Conversation
MatkovIvan
reviewed
Aug 26, 2022
MatkovIvan
suggested changes
Aug 26, 2022
| throw new Exception("Unexpected content of Debugger.cpp"); | ||
| } | ||
|
|
||
| #if UNITY_VERSION < UNITY_2021 |
Contributor
There was a problem hiding this comment.
You need to provide fix for new versions or do not call this method at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
CHANGELOG.mdbeen updated?Description
Added compiler condition for Windows.h, #undef GetCurrentDirectory and logging method.
Related PRs or issues
AB#91924
#513