Skip to content

Fix build APPX packages on version 2021.X.X and higher #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksandr-dorofeev wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix build APPX packages on version 2021.X.X and higher #520

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b85a8da
Add condition
Aug 26, 2022
1512adc
Change condition
Aug 26, 2022
e5ceaa1
Add condition for Unity_2021
Sep 8, 2022
b58bd74
Remove comment lines
Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Assets/AppCenter/Editor/AppCenterPostBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public static void FixIl2CppLogging(string pathToBuiltProject)
throw new Exception("Unexpected content of Debugger.cpp");
}

#if UNITY_VERSION < UNITY_2021
Copy link
Contributor

@MatkovIvan MatkovIvan Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to provide fix for new versions or do not call this method at all

// Add '#include <Windows.h>' which provides 'OutputDebugStringW'.
codeLines.Insert(lastIncludeLineIndex + 1, "#include <Windows.h>");

Expand All @@ -105,15 +106,18 @@ public static void FixIl2CppLogging(string pathToBuiltProject)
* combine some files on the compilation so the changes in one file can affect another.
*/
codeLines.Insert(lastIncludeLineIndex + 2, "#undef GetCurrentDirectory");

#endif
// Add logging method.
var logMethodLineIndex = SearchForLine(codeLines, "void Debugger::Log");
if (logMethodLineIndex == -1)
{
throw new Exception("Unexpected content of Debugger.cpp");
}

#if UNITY_VERSION < UNITY_2021
var insertingPosition = GetFirstLineInMethodBody(codeLines, logMethodLineIndex);
codeLines.Insert(insertingPosition, "OutputDebugStringW(message->chars);");
#endif

// Enable logging.
var isLoggingMethodLineIndex = SearchForLine(codeLines, "bool Debugger::IsLogging");
Expand Down Expand Up @@ -284,9 +288,9 @@ internal static string GetAttributeValue(XElement element, string attributeName)
return attribute == null ? null : attribute.Value;
}

#endregion
#endregion

#region iOS Methods
#region iOS Methods
private static void OnPostprocessProject(PBXProjectWrapper project)
{
// Need to add SQLite and zlib dependencies.
Expand Down Expand Up @@ -336,5 +340,5 @@ private static void OnPostprocessInfo(PlistDocumentWrapper info, AppCenterSettin
}
}

#endregion
#endregion
}