Skip to content

Check container_uri for container_name #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

adam-grofe
Copy link
Contributor

One of the chemistry users reported a bug, where they changed the name of the container that the job uses during the run. This appears to work fine for submitting and running the job, but they experienced errors when trying to download the data using download attachment function where it would use the default name of the container instead. This PR fixes this bug by first checking whether the container uri is instantiated and if so, then parsing the container name from it.

@adam-grofe adam-grofe requested a review from a team as a code owner April 22, 2025 21:03
@adam-grofe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adam-grofe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adam-grofe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kikomiss
Copy link
Collaborator

kikomiss commented May 7, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adam-grofe adam-grofe closed this May 9, 2025
@adam-grofe adam-grofe reopened this May 9, 2025
@adam-grofe adam-grofe enabled auto-merge (squash) May 9, 2025 14:08
@adam-grofe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adam-grofe adam-grofe merged commit 5798eb4 into main May 9, 2025
6 checks passed
@adam-grofe adam-grofe deleted the adamgrofe/bugfix/rename_container branch May 9, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants