Skip to content

Check container_uri for container_name #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Check container_uri for container_name #672

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20423a6
Check container_uri for container_name
Apr 22, 2025
2455e31
Merge branch 'main' into adamgrofe/bugfix/rename_container
kikomiss May 7, 2025
939ddbd
Merge branch 'main' into adamgrofe/bugfix/rename_container
adam-grofe May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions azure-quantum/azure/quantum/job/base_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,14 @@ def details(self, value: JobDetails):
@property
def container_name(self):
"""Job input/output data container name"""
return f"job-{self.id}"

if self._details.container_uri is None:
return f"job-{self.id}"
else:
container_uri = self._details.container_uri
path = urlparse(container_uri).path
container_name = path.split("/")[1]
return container_name

@classmethod
def from_input_data(
Expand Down Expand Up @@ -323,7 +330,10 @@ def upload_attachment(

# Use Job's default container if not specified
if container_uri is None:
container_uri = self.workspace.get_container_uri(job_id=self.id)
if self._details.container_uri is None:
container_uri = self.workspace.get_container_uri(job_id=self.id)
else:
container_uri = self._details.container_uri

uploaded_blob_uri = self.upload_input_data(
container_uri = container_uri,
Expand Down Expand Up @@ -353,7 +363,10 @@ def download_attachment(

# Use Job's default container if not specified
if container_uri is None:
container_uri = self.workspace.get_container_uri(job_id=self.id)
if self._details.container_uri is None:
container_uri = self.workspace.get_container_uri(job_id=self.id)
else:
container_uri = self._details.container_uri

container_client = ContainerClient.from_container_url(container_uri)
blob_client = container_client.get_blob_client(name)
Expand Down
Loading