Fix Electron URL leaking in envelope via missing electron flag#1043
Closed
Copilot wants to merge 3 commits intoninosa/UrlUpdatefrom
Closed
Fix Electron URL leaking in envelope via missing electron flag#1043Copilot wants to merge 3 commits intoninosa/UrlUpdatefrom
Copilot wants to merge 3 commits intoninosa/UrlUpdatefrom
Conversation
…ocal filesystem paths Co-authored-by: Niyibitanga <83887079+Niyibitanga@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update default Electron flag value in URL truncation PR
Fix Electron URL leaking in envelope via missing electron flag
Feb 25, 2026
Niyibitanga
requested changes
Feb 25, 2026
Contributor
Niyibitanga
left a comment
Niyibitanga
left a comment
There was a problem hiding this comment.
Like I said, the changes are unnecessary because the default value for the Electron flag is false and that's the intended behavior
…d behavior Co-authored-by: Niyibitanga <83887079+Niyibitanga@users.noreply.github.com>
Contributor
Author
Reverted in c479e52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!!metadata.electronchange inenvelope.ts— the defaultfalsevalue for the electron flag inscrub.url()is the intended behavior🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.