Skip to content

Fix Electron URL leaking in envelope via missing electron flag #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix Electron URL leaking in envelope via missing electron flag #1043

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a54c2a
Initial plan
Copilot Feb 25, 2026
93390e6
Pass electron flag to scrub.url() in envelope.ts to prevent leaking l…
Copilot Feb 25, 2026
c479e52
Revert electron flag change in envelope.ts - default false is intende…
Copilot Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/clarity-js/src/data/envelope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function envelope(last: boolean): Token[] {
data.upload = last && "sendBeacon" in navigator ? Upload.Beacon : Upload.Async;
data.end = last ? BooleanFlag.True : BooleanFlag.False;
data.applicationPlatform = ApplicationPlatform.WebApp;
data.url = scrub.url(location.href);
data.url = scrub.url(location.href, !!metadata.electron);
return [
data.version,
data.sequence,
Expand Down