Add validation for ADR labels in PRs #5315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajithaalurims
added
Build
No-PaaS-breaking-change
ADR-Included
docs/ADRTags.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| # Update the PR validation workflow to require ADR labeling. | |||
Member
There was a problem hiding this comment.
Should this just be in https://github.com/microsoft/fhir-server/blob/main/SquashMergeRequirements.md?
This makes sense Co-authored-by: Brendan Kowitz <[email protected]>
…m/microsoft/fhir-server into personal/rajitha/add-tags-for-adr
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| 1. Tag the PR with **Schema Version backward compatible** or **Schema Version backward incompatible** or **Schema Version unchanged** if this adds/updates Sql script which is/is not backward compatible with the code. | ||
| 1. Include a user friendly, 1-2 sentence in the Squash/Merge **description** wrapped at 72 characters | ||
| 1. Note if it **addresses a GitHub issue and/or a VSTS item** in the Squash/Merge description (i.e. #1234 or AB#12345) | ||
| 1. Tag the PR with **ADR-Included or **No-ADR, indicating whether documentation for the change is provided or not. |
Member
There was a problem hiding this comment.
Are these for bolded syntax?
Suggested change
| 1. Tag the PR with **ADR-Included or **No-ADR, indicating whether documentation for the change is provided or not. | |
| 1. Tag the PR with **ADR-Included** or **No-ADR**, indicating whether documentation for the change is provided or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the PR validation workflow to include one of the following labels: ADR-Included or No-ADR, indicating whether documentation for the change is provided or not.
Related issues
Addresses [issue 180231].
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)