Skip to content

Add validation for ADR labels in PRs #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajithaalurims wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add validation for ADR labels in PRs #5315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
874bb2b
Add validation for ADR labels in PRs
rajithaalurims Jan 7, 2026
6257ab0
Update .github/workflows/validate-prs.yml
rajithaalurims Jan 8, 2026
484662a
SquashMergeRequirements doc updated
rajithaalurims Jan 8, 2026
5ed0d0c
Merge branch 'personal/rajitha/add-tags-for-adr' of https://github.co…
rajithaalurims Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/validate-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ jobs:
errors += '- Tag the PR with **No-PaaS-breaking-change** or **PaaS-breaking-change** to indicate PaaS compatibility. \n';
}

if(labels.includes("ADR-Included") == false &&
labels.includes("No-ADR") == false) {
errors += '- Tag the PR with **No-ADR** or **ADR-Included** to indicate whether documentation for the change is provided or not. \n';
}

if(errors != "") {
core.setFailed(errors)
}
5 changes: 5 additions & 0 deletions docs/ADRTags.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Update the PR validation workflow to require ADR labeling.
Copy link
Member

@brendankowitz brendankowitz Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be in https://github.com/microsoft/fhir-server/blob/main/SquashMergeRequirements.md?

Copy link
Contributor Author

@rajithaalurims rajithaalurims Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


- All pull requests must now include one of the following labels: ADR-Included or No-ADR, indicating whether documentation for the change is provided or not.

- This ensures that every change is accompanied by its rationale and details, making it easier to track the context behind modifications in the future without scrambling to figure out who made the change and why.
Loading