Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Clean up Vite boilerplate content - UX web app for marketing site and management portal #1024

Conversation

akiskips
Copy link
Contributor

@akiskips akiskips commented Oct 1, 2024

πŸ› οΈ Description

Removed some of the boilerplate code of the Vite React template.
Listed two commands to start the dev server and build the project on the Readme.md

πŸ“· Screenshots

image

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@akiskips akiskips added Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed labels Oct 1, 2024
@akiskips akiskips requested a review from a team October 1, 2024 18:07
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers label Oct 1, 2024
@akiskips akiskips linked an issue Oct 1, 2024 that may be closed by this pull request
@akiskips
Copy link
Contributor Author

akiskips commented Oct 1, 2024

@microsoft-github-policy-service agree

src/web/index.html Outdated Show resolved Hide resolved
src/web/pages/App.tsx Outdated Show resolved Hide resolved
src/web/pages/App.tsx Outdated Show resolved Hide resolved
src/web/pages/App.tsx Outdated Show resolved Hide resolved
src/web/README.md Outdated Show resolved Hide resolved
src/web/README.md Outdated Show resolved Hide resolved
@flanakin flanakin requested a review from Ivanmtta October 1, 2024 23:22
@flanakin flanakin added the Tool: Web app Web app to learn about and manage toolkit resources. label Oct 1, 2024
@flanakin
Copy link
Collaborator

flanakin commented Oct 1, 2024

@allcontributors Please add akiskips for code

Copy link
Contributor

@flanakin

I've put up a pull request to add @akiskips! πŸŽ‰

},
rules: {
...reactHooks.configs.recommended.rules,
'react-refresh/only-export-components': [
'warn',
{ allowConstantExport: true },
],
// Enable its recommended rules
...react.configs.recommended.rules,
...react.configs['jsx-runtime'].rules,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

@flanakin flanakin added Status: ▢️ Ready Issue is ready for a dev to start work and removed Needs: Review πŸ‘€ PR that is ready to be reviewed labels Oct 1, 2024
akiskips and others added 3 commits October 2, 2024 18:29
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
akiskips and others added 3 commits October 2, 2024 18:30
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
src/web/index.html Outdated Show resolved Hide resolved
@flanakin flanakin merged commit cb2eb81 into microsoft:features/ux Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: ▢️ Ready Issue is ready for a dev to start work Tool: Web app Web app to learn about and manage toolkit resources.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Clean up Vite boilerplate content
4 participants