Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Clean up Vite boilerplate content - UX web app for marketing site and management portal #1024

Merged
merged 10 commits into from
Oct 4, 2024
Merged

[UX] Clean up Vite boilerplate content - UX web app for marketing site and management portal #1024

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
516f624
removing boilerplate of template
Oct 1, 2024
9b2c9a5
expanded the ESLint based on the template suggestions for prod
Oct 1, 2024
f31be69
update readme
Oct 1, 2024
c80e621
Update src/web/index.html
akiskips Oct 2, 2024
3a810af
Update src/web/pages/App.tsx
akiskips Oct 2, 2024
f8b585b
Update src/web/pages/App.tsx
akiskips Oct 2, 2024
644277e
Update src/web/pages/App.tsx
akiskips Oct 2, 2024
c8b6fe2
Update src/web/README.md
akiskips Oct 2, 2024
4b614d9
Update src/web/README.md
akiskips Oct 2, 2024
0f70b81
Apply suggestions from code review
flanakin Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/web/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# React + TypeScript + Vite

To start the development server, navigate to src/web folderand run:
```npm install```
and then
```npm run dev```
akiskips marked this conversation as resolved.
Show resolved Hide resolved

----------------------------------------------------------------------------------------------------------------------------
akiskips marked this conversation as resolved.
Show resolved Hide resolved
This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.

Currently, two official plugins are available:
Expand Down
1 change: 0 additions & 1 deletion src/web/assets/react.svg
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion src/web/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ import globals from 'globals'
import reactHooks from 'eslint-plugin-react-hooks'
import reactRefresh from 'eslint-plugin-react-refresh'
import tseslint from 'typescript-eslint'
import react from 'eslint-plugin-react'

export default tseslint.config(
{ ignores: ['dist'] },
{
extends: [js.configs.recommended, ...tseslint.configs.recommended],
extends: [js.configs.recommended, ...tseslint.configs.recommendedTypeChecked],
files: ['**/*.{ts,tsx}'],
languageOptions: {
ecmaVersion: 2020,
Expand All @@ -16,13 +17,17 @@ export default tseslint.config(
plugins: {
'react-hooks': reactHooks,
'react-refresh': reactRefresh,
react,
},
rules: {
...reactHooks.configs.recommended.rules,
'react-refresh/only-export-components': [
'warn',
{ allowConstantExport: true },
],
// Enable its recommended rules
...react.configs.recommended.rules,
...react.configs['jsx-runtime'].rules,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

},
},
)
3 changes: 1 addition & 2 deletions src/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite + React + TS</title>
<title>FinOps tookit Marketing Site</title>
akiskips marked this conversation as resolved.
Show resolved Hide resolved
</head>
<body>
<div id="root"></div>
Expand Down
Loading