[dev-v5][CounterBadge] Change Count type to int #4465
Merged
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow specifying OverflowCount in example - Update some test
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.8%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the FluentCounterBadge component to change the Count parameter type from ushort? to int?, making it consistent with the existing OverflowCount parameter type and supporting a wider range of values.
Changes:
- Changed the
Countparameter type fromushort?toint?in FluentCounterBadge component - Updated demo component to support overflow count input and use
int.TryParseinstead ofUInt16.TryParse - Updated tests to validate the new
inttype and added verification for count attribute rendering with overflow
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/Core/Components/Badge/FluentCounterBadge.razor.cs | Changed Count parameter from ushort? to int? to support wider range of values and consistency with OverflowCount |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor.cs | Added overflowcount variable to support overflow count demonstration |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor | Updated parsing logic from UInt16.TryParse to int.TryParse and added overflow count input field |
| tests/Core/Components/Badge/FluentCounterBadgeTests.razor | Updated Count type assertions, modified CountOutOfRange test logic, added count attribute verification in overflow test, and removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...Demo.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor
Outdated
Show resolved
Hide resolved
...o.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor.cs
Outdated
Show resolved
Hide resolved
...o.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor.cs
Outdated
Show resolved
Hide resolved
dvoituron
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
FluentCounterBadgecomponent to improve its handling of count values by switching fromushort?toint?for theCountparameter, adds support for an overflow count in the demo, and updates related tests to reflect these changes. The changes enhance flexibility and robustness, especially for larger count values and overflow scenarios.Component enhancements:
Countparameter type inFluentCounterBadgefromushort?toint?to support a wider range of values. (src/Core/Components/Badge/FluentCounterBadge.razor.cssrc/Core/Components/Badge/FluentCounterBadge.razor.csL56-R56)CountandOverflowCountto useintinstead ofushort. (examples/Demo/FluentUI.Demo.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor[1] [2]Testing improvements:
inttype forCount, including handling values out of range and verifying correct attribute rendering when overflow occurs. (tests/Core/Components/Badge/FluentCounterBadgeTests.razor[1] [2] [3]