Skip to content

[dev-v5][CounterBadge] Change Count type to int #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 4 commits into from
Jan 13, 2026
+15 −11
Merged

[dev-v5][CounterBadge] Change Count type to int #4465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb56bc2
- Change Count type to int
vnbaaij Jan 13, 2026
bac48f2
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/counterbadge-int
vnbaaij Jan 13, 2026
c6df432
Process review comments
vnbaaij Jan 13, 2026
c8c74b0
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/counterbadge-int
dvoituron Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...o.Client/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,17 @@
<FluentStack VerticalAlignment="VerticalAlignment.Top">
<span>
<FluentStack HorizontalAlignment="HorizontalAlignment.Left" Orientation="Orientation.Vertical">
<FluentTextInput InputMode="TextInputMode.Numeric" @bind-Value="@count" Label="Count" AutoComplete="off" />
<FluentTextInput InputMode="TextInputMode.Numeric" @bind-Value="@offsetX" Label="Offset X" AutoComplete="off" />
<FluentTextInput InputMode="TextInputMode.Numeric" @bind-Value="@count" Label="Count" AutoComplete="off" />
<FluentTextInput InputMode="TextInputMode.Numeric" @bind-Value="@overflowCount" Label="Overflow count" AutoComplete="off" />
<FluentTextInput InputMode="TextInputMode.Numeric" @bind-Value="@offsetX" Label="Offset X" AutoComplete="off" />
<FluentTextInput InputMode="TextInputMode.Numeric" @bind-Value="@offsetY" Label="Offset Y" AutoComplete="off" />
</FluentStack>
</span>
<div class="grid">
<div style="grid-area:contents">
<FluentCounterBadge Color="BadgeColor.Danger"
Count="@(UInt16.TryParse(count, out ushort c) ? c : null)"
Count="@(int.TryParse(count, out int c) ? c : null)"
OverflowCount="@(int.TryParse(overflowCount, out int oc) ? oc : null)"
OffsetX="@(SByte.TryParse(offsetX, out sbyte x) ? x : null)"
OffsetY="@(SByte.TryParse(offsetY, out sbyte y) ? y : null)"
Size="BadgeSize.Small"
Expand Down
1 change: 1 addition & 0 deletions ...lient/Documentation/Components/Badges/CounterBadge/Examples/CounterBadgeAttached.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace FluentUI.Demo.Client.Documentation.Components.Badges.CounterBadge.Exam
public partial class CounterBadgeAttached
{
private string? count = "3";
private string? overflowCount = string.Empty;
private string? offsetX;
private string? offsetY;

Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/Badge/FluentCounterBadge.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public FluentCounterBadge(LibraryConfiguration configuration) : base(configurati
/// With ShowZero being false by default, the default result will be an empty counter badge
/// </summary>
[Parameter]
public ushort? Count { get; set; }
public int? Count { get; set; }

/// <summary>
/// Gets or sets the badge's overflow count.
Expand Down
15 changes: 8 additions & 7 deletions tests/Core/Components/Badge/FluentCounterBadgeTests.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,22 @@

// Assert
var cb = cut.FindComponent<FluentCounterBadge>();
Assert.Equal((ushort?)3, cb.Instance.Count);
Assert.Equal(3, cb.Instance.Count);
}

[Fact]
public void FluentCounterBadge_CountOutOfRange()
{
// Arrange && Act
var cut = Render(@<FluentCounterBadge Count="256" />);
// Arrange
long c = (long)int.MaxValue + 1;

// Act
var cut = Render(@<FluentCounterBadge Count="@((int)c)" />);

// Assert
Assert.NotNull(cut.Find("fluent-counter-badge"));
var count = cut.Find("fluent-counter-badge").GetAttribute("count");
Assert.Equal("256", count);
Assert.Null(count);
}

[Theory]
Expand Down Expand Up @@ -227,6 +230,7 @@
var cut = Render(@<FluentCounterBadge Count="11" OverflowCount="10" />);
// Assert
Assert.Equal("10", cut.Find("fluent-counter-badge").GetAttribute("overflow-count"));
Assert.Equal("11", cut.Find("fluent-counter-badge").GetAttribute("count"));
}

[Fact]
Expand Down Expand Up @@ -403,6 +407,3 @@
Assert.NotNull(cb);
}
}



Loading