[TestSuit] Fix CanDoSRANDMEMBERWithCountCommandLC test #1143
+39
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalZaccai
requested changes
Apr 3, 2025
prvyk
force-pushed
the
CanDoSRANDMEMBERTest
branch
from
98ad5a4 to
2a3e5d7
Compare
prvyk
commented
Apr 5, 2025
prvyk
force-pushed
the
CanDoSRANDMEMBERTest
branch
from
2a3e5d7 to
c7bd663
Compare
prvyk
force-pushed
the
CanDoSRANDMEMBERTest
branch
from
c7bd663 to
3f57609
Compare
prvyk
force-pushed
the
CanDoSRANDMEMBERTest
branch
3 times, most recently
from
5eec15f to
0eab7d4
Compare
Fix remaining Encoding.ASCII.GetString usages.
prvyk
force-pushed
the
CanDoSRANDMEMBERTest
branch
from
0eab7d4 to
790d92c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test didn't really test for duplicate members, because it didn't update arrLenEndIdx, so the next loop run just compared against the previous - passing regardless of actual behaviour (which happened to be per spec, but the test should still work).
Also fix remaining Encoding.ASCII.GetString usages.