Skip to content

[TestSuit] Fix CanDoSRANDMEMBERWithCountCommandLC test #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[TestSuit] Fix CanDoSRANDMEMBERWithCountCommandLC test #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee05fab
Fix CanDoSRANDMEMBERWithCountCommandLC test
prvyk May 21, 2025
0619619
Convert test to GarnetClientSession.
prvyk May 21, 2025
27be6eb
Go back to lightClient. Add a simple RESP parsing class to verify res…
prvyk Jun 4, 2025
5e187e2
Add some RESP3 types to simple reader.
prvyk Jun 5, 2025
7262757
fmt
prvyk Jun 6, 2025
df30b6b
No need for unsafe now.
prvyk Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/Garnet.test/GarnetServerConfigTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,7 @@ public async Task MultiTcpSocketTest()
var hostname = TestUtils.GetHostName();
var addresses = Dns.GetHostAddresses(hostname);
addresses = [.. addresses, IPAddress.IPv6Loopback, IPAddress.Loopback];
addresses = [.. addresses.Distinct()];

var endpoints = addresses.Select(address => new IPEndPoint(address, TestUtils.TestPort)).ToArray();
var server = TestUtils.CreateGarnetServer(TestUtils.MethodTestDir, endpoints: endpoints);
Expand Down
164 changes: 164 additions & 0 deletions test/Garnet.test/Resp/TestSimpleReadRESP.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

using System;
using System.Collections.Generic;
using System.Text;
using Garnet.common.Parsing;

namespace Garnet.test
{
public static class TestSimpleReadRESP
{
public static object[] ReadRESP(byte[] inputArray)
{
var pos = 0;
var input = Encoding.ASCII.GetString(inputArray);

return Read(input, ref pos);
}

public static object[] ReadRESP(string input)
{
var pos = 0;
return Read(input, ref pos);
}

static object[] Read(string input, ref int pos)
{
switch (input[pos])
{
case ':':
pos++;
var resultInt = ReadIntegerAsString(input, ref pos);
return [resultInt];

case '$':
case '~':
case '%':
pos++;
var resultBulk = ReadStringWithLengthHeader(input, ref pos);
return [resultBulk];

case '*':
pos++;
var resultArray = ReadStringArrayWithLengthHeader(input, ref pos);
return resultArray;

case '+':
pos++;
var resultString = ReadSimpleString(input, ref pos);
return [resultString];

case '-':
pos++;
var errorString = ReadErrorAsString(input, ref pos);
return [errorString];

case ',':
pos++;
var resultDouble = ReadDoubleAsString(input, ref pos);
return [resultDouble];

default:
RespParsingException.Throw($"Unexpected character {input[0]}");
throw new NotImplementedException();
}
}

private static object[] ReadStringArrayWithLengthHeader(string input, ref int loc)
{
var pos = input.IndexOf("\r\n", loc);
if (pos == -1)
RespParsingException.Throw("No newline");

var arraylen = int.Parse(input[loc..pos]);
loc = pos + 2;

if (arraylen < 0)
RespParsingException.ThrowInvalidLength(arraylen);

List<object> lo = new(arraylen);
for (var i = 0; i < arraylen; i++)
{
var res = Read(input, ref loc);
lo.AddRange(res);
}

return [.. lo];
}

private static string ReadStringWithLengthHeader(string input, ref int loc)
{
var pos = input.IndexOf("\r\n", loc);
if (pos == -1)
RespParsingException.Throw("No newline");

var len = int.Parse(input[loc..pos]);
if (len < -1)
RespParsingException.ThrowInvalidStringLength(len);

loc = input.IndexOf("\r\n", pos + 2) + 2;
if (loc < 0)
RespParsingException.Throw("No newline!");

if (len == -1)
{
return null;
}

if (loc != pos + 2 + len + 2)
RespParsingException.Throw("Invalid length!");

return input[(pos + 2)..(pos + 2 + len)];
}

private static string ReadErrorAsString(string input, ref int loc)
{
var pos = input.IndexOf("\r\n", loc);
if (pos == -1)
RespParsingException.Throw("No newline");

var ret = input[loc..pos];
loc = pos + 2;

return ret;
}

private static double ReadDoubleAsString(string input, ref int loc)
{
var pos = input.IndexOf("\r\n", loc);
if (pos == -1)
RespParsingException.Throw("No newline");

var ret = double.Parse(input[loc..pos]);
loc = pos + 2;

return ret;
}

private static long ReadIntegerAsString(string input, ref int loc)
{
var pos = input.IndexOf("\r\n", loc);
if (pos == -1)
RespParsingException.Throw("No newline");

var ret = long.Parse(input[loc..pos]);
loc = pos + 2;

return ret;
}

private static string ReadSimpleString(string input, ref int loc)
{
var pos = input.IndexOf("\r\n", loc);
if (pos == -1)
RespParsingException.Throw("No newline");

var ret = input[loc..pos];
loc = pos + 2;

return ret;
}
}
}
6 changes: 2 additions & 4 deletions test/Garnet.test/RespBlockingCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,8 +961,7 @@ public async Task BasicBzmpopWithExpireItemsTest(string mode)
using var lcr = TestUtils.CreateRequest();
var response = lcr.SendCommand($"BZMPOP 1 1 {key} {mode}");
var expectedResponse = "$-1\r\n";
var actualValue = Encoding.ASCII.GetString(response).Substring(0, expectedResponse.Length);
ClassicAssert.AreEqual(expectedResponse, actualValue);
TestUtils.AssertEqualUpToExpectedLength(expectedResponse, response);
}

[Test]
Expand Down Expand Up @@ -1079,8 +1078,7 @@ public async Task BasicBzpopMinMaxWithExpireItemsTest(string command)
using var lcr = TestUtils.CreateRequest();
var response = lcr.SendCommand($"{command} {key} 1");
var expectedResponse = "$-1\r\n";
var actualValue = Encoding.ASCII.GetString(response).Substring(0, expectedResponse.Length);
ClassicAssert.AreEqual(expectedResponse, actualValue);
TestUtils.AssertEqualUpToExpectedLength(expectedResponse, response);
}

[Test]
Expand Down
36 changes: 8 additions & 28 deletions test/Garnet.test/RespSetTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,43 +1025,23 @@ public void CanDoSRANDMEMBERWithCountCommandLC()
CreateLongSet();

response = lightClientRequest.SendCommand("SRANDMEMBER myset", 1);
var strLen = Encoding.ASCII.GetString(response).Substring(1, 1);
var item = Encoding.ASCII.GetString(response).Substring(4, Int32.Parse(strLen));
var strLen = Encoding.ASCII.GetString(response, 1, 1);
var item = Encoding.ASCII.GetString(response, 4, int.Parse(strLen));
ClassicAssert.IsTrue(myset.Contains(item));

// Get three random members
response = lightClientRequest.SendCommand("SRANDMEMBER myset 3", 3);
TestUtils.AssertEqualUpToExpectedLength("*", response);

var strResponse = Encoding.ASCII.GetString(response);
var arrLenEndIdx = strResponse.IndexOf("\r\n", StringComparison.InvariantCultureIgnoreCase);
ClassicAssert.IsTrue(arrLenEndIdx > 1);

var strArrLen = strResponse.AsSpan().Slice(1, arrLenEndIdx - 1);
ClassicAssert.IsTrue(int.TryParse(strArrLen, out var arrLen));
ClassicAssert.AreEqual(3, arrLen);
TestUtils.AssertEqualUpToExpectedLength("*3\r\n", response);

// Get 6 random members and verify that at least two elements are the same
response = lightClientRequest.SendCommand("SRANDMEMBER myset -6", 6);
var strReponse = Encoding.ASCII.GetString(response);
arrLenEndIdx = strReponse.IndexOf("\r\n", StringComparison.InvariantCultureIgnoreCase);
strArrLen = strReponse.AsSpan().Slice(1, arrLenEndIdx - 1);
ClassicAssert.IsTrue(int.TryParse(strArrLen, out arrLen));
TestUtils.AssertEqualUpToExpectedLength("*6\r\n", response);

var members = new HashSet<string>();
var repeatedMembers = false;
for (var i = 0; i < arrLen; i++)
{
var member = strReponse.Substring(arrLenEndIdx + 2, response.Length - arrLenEndIdx - 5);
if (members.Contains(member))
{
repeatedMembers = true;
break;
}
members.Add(member);
}
var results = TestSimpleReadRESP.ReadRESP(response);

ClassicAssert.IsTrue(repeatedMembers, "At least two members are repeated.");
ClassicAssert.IsTrue(results.All(a => myset.Contains((string)a)));
ClassicAssert.IsTrue(results.Distinct().Count() != results.Length,
"At least two members must be repeated.");
}

[Test]
Expand Down
3 changes: 2 additions & 1 deletion test/Garnet.test/RespTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5024,7 +5024,7 @@ public async Task ClientUnblockBasicTest(string clientType, string mode, bool ex
{
var startTime = Stopwatch.GetTimestamp();
var response = blockingClient.SendCommand("BLMPOP 10 1 keyA LEFT");
if (Encoding.ASCII.GetString(response).Substring(0, "-UNBLOCKED".Length) == "-UNBLOCKED")
if (Encoding.ASCII.GetString(response, 0, "-UNBLOCKED".Length) == "-UNBLOCKED")
{
isError = true;
}
Expand Down Expand Up @@ -5077,6 +5077,7 @@ public async Task MultipleClientsUnblockAndAddTest(int numberOfItems)
using var blockingClient = TestUtils.CreateRequest();
var clientIdResponse = Encoding.ASCII.GetString(blockingClient.SendCommand("CLIENT ID"));
var clientId = clientIdResponse.Substring(1, clientIdResponse.IndexOf("\r\n") - 1);
ClassicAssert.IsTrue(long.TryParse(clientId, out _));

string blockingResult = null;
var blockingTask = Task.Run(() =>
Expand Down