No float from chars on gcc9 #24393
Open
No float from chars on gcc9 #24393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…below. This could possibly be trimmed to 10, but I don't have a possibility to test this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't use std::from_chars for gcc (libstdc++) before version 12. While gcc 11.x does have from_chars it is only in gcc12 that the implementation was fast.
Explicitly void cast a variable that was erroneously flagged as unused by gcc 9 due to imperfect implementation of if constexpr in combination with "warnings as errors" in your build process.
Motivation and Context