Skip to content

No float from chars on gcc9 #24393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −1
Open

No float from chars on gcc9 #24393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afa025f
Add if clause to avoid using float from_chars overload on gcc 11 and …
BengtGustafssonCoV Mar 25, 2025
19df87b
Another gcc 9 fix
BengtGustafssonCoV Mar 25, 2025
143e0d4
Merge branch 'microsoft:main' into NoFloatFromCharsOnGcc9
BengtGustafsson Apr 11, 2025
70fa611
Merge remote-tracking branch 'origin/main' into NoFloatFromCharsOnGcc9
BengtGustafssonCoV Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/onnxruntime/core/common/parse_string.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace onnxruntime {
namespace detail {

// Whether we will use std::from_chars() to parse to `T`.
#if defined(_LIBCPP_VERSION)
#if defined(_LIBCPP_VERSION) || defined(__GNUC__) && __GNUC__ < 12
// Note: Currently (e.g., in LLVM 19), libc++'s std::from_chars() doesn't support floating point types yet.
template <typename T>
constexpr bool ParseWithFromChars = !std::is_same_v<bool, T> && std::is_integral_v<T>;
Expand Down
1 change: 1 addition & 0 deletions onnxruntime/contrib_ops/cpu/sparse/sparse_attention_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ class SparseAttentionBase {
v, head_size, output_current, hidden_size,
MLFloat16(1.0f).val, static_cast<uint16_t>(0) /*beta*/, nullptr);
} else {
(void) output_current; // Silence gcc 9.
size_t bytes = static_cast<size_t>(head_size) * total_seq_len * sizeof(float);
auto v_fp32 = allocator->Alloc(bytes);
BufferUniquePtr scratch_buffer(v_fp32, BufferDeleter(allocator));
Expand Down