[CORE]: Improve filesystem error messages during Linux device discovery#27289
Open
theHamsta wants to merge 2 commits intomicrosoft:mainfrom
Open
[CORE]: Improve filesystem error messages during Linux device discovery#27289theHamsta wants to merge 2 commits intomicrosoft:mainfrom
theHamsta wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…covery) Review dog lints: https://github.com/microsoft/onnxruntime/pull/26210/changes Plus a typo: `dit` -> `did`
ErrorCodeToStatus currently does not include the filesystem path that caused the error. This could it make difficult to know the root cause of a reported filesystem error.
theHamsta
commented
Feb 9, 2026
| namespace { | ||
|
|
||
| Status ErrorCodeToStatus(const std::error_code& ec) { | ||
| Status ErrorCodeToStatus(const std::error_code& ec, const fs::path& path, std::string_view context) { |
Contributor
Author
There was a problem hiding this comment.
the string "context" could be overkill. I thought it would provide useful context, why we accessed the file. But I would at least include the filesystem path that caused the error code. Otherwise, debugging the error code could be difficult
theHamsta
changed the title
theHamsta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #26210
to address #26210 (comment) and review dog lints.
ErrorCodeToStatus currently does not include the filesystem path that
caused the error. This could it make difficult to know the root cause
of a reported filesystem error.
Review dog lints: https://github.com/microsoft/onnxruntime/pull/26210/changes
Plus a typo:
dit->didMotivation and Context
Clean up discussed issues and lints of #26210