Skip to content

Improve encapsulation of weight_data_type_freq_ #27292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuslepukhin merged 3 commits into from
Feb 11, 2026
Merged

Improve encapsulation of weight_data_type_freq_ #27292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27019c2
Improve encapsulation of weight_data_type_freq_
ashrit-ms Feb 9, 2026
f0790c5
Address patch 1 comments
ashrit-ms Feb 9, 2026
17f0eba
Fix build errors
ashrit-ms Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion include/onnxruntime/core/graph/graph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,13 @@ class Graph { // NOLINT(clang-analyzer-optin.performance.Padding): preserve exi
bool IsSparseInitializer(const std::string& name) const;
#endif

#if !defined(ORT_MINIMAL_BUILD)
/** Gets the frequency count of weight data types in this graph. */
gsl::span<const int32_t> GetWeightDataTypeFrequency() const noexcept {
return weight_data_type_freq_;
}
#endif

/** Gets an initializer tensor with the provided name.
@param[out] value Set to the TensorProto* if the initializer is found, or nullptr if not.
@returns True if found.
Expand Down Expand Up @@ -1608,9 +1615,9 @@ class Graph { // NOLINT(clang-analyzer-optin.performance.Padding): preserve exi

ORT_DISALLOW_COPY_ASSIGNMENT_AND_MOVE(Graph);

private:
int32_t weight_data_type_freq_[ONNX_NAMESPACE::TensorProto_DataType_DataType_ARRAYSIZE] = {0};

private:
void InitializeStateFromModelFileGraphProto();

// Add node with specified <node_proto>.
Expand Down
9 changes: 5 additions & 4 deletions onnxruntime/core/session/inference_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1818,15 +1818,16 @@ static bool ModelHasFP16Inputs(const Graph& graph) {
#if !defined(ORT_MINIMAL_BUILD)
[[maybe_unused]] static std::string ModelWeightDataType(const Graph& graph) {
std::string data_type_list;
auto weight_freq = graph.GetWeightDataTypeFrequency();

for (int i = 0; i < ONNX_NAMESPACE::TensorProto_DataType_DataType_ARRAYSIZE; ++i) {
if (graph.weight_data_type_freq_[i] > 0) {
for (size_t i = 0; i < weight_freq.size(); ++i) {
if (weight_freq[i] > 0) {
if (!data_type_list.empty()) {
data_type_list += ", ";
}
data_type_list += TensorProto_DataType_Name(i);
data_type_list += TensorProto_DataType_Name(static_cast<int>(i));
data_type_list += ": ";
data_type_list += std::to_string(graph.weight_data_type_freq_[i]);
data_type_list += std::to_string(weight_freq[i]);
}
}

Expand Down
Loading