Enable ONNX backend tests on [U]INT4 types in Cast#27326
Open
mcollinswisc wants to merge 3 commits intomicrosoft:mainfrom
Open
Enable ONNX backend tests on [U]INT4 types in Cast#27326mcollinswisc wants to merge 3 commits intomicrosoft:mainfrom
mcollinswisc wants to merge 3 commits intomicrosoft:mainfrom
Conversation
The ONNX submodule now points to 1.20.1: microsoft#26579
Apparently resolved by microsoft@51b678f microsoft#26579
mcollinswisc
commented
Feb 12, 2026
| .MayInplace(0, 0), // allocation planner will check input and output sizes match before inplacing | ||
| Cast); | ||
|
|
||
| // TODO(adrianlizarraga): Implement support for int4 and uint4. |
Contributor
Author
There was a problem hiding this comment.
@adrianlizarraga Does the support added since cd7112f meet the intention of this TODO?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for [U]INT4 types in Cast op was added in:
51b678f
The comment on the skipped tests say they need ONNX 1.19. The ONNX submodule now points to 1.20.1:
de398c4
And if I run each of these they seem to work now:
Also removing an old TODO from
cd7112f
Motivation and Context
I was trying out INT4 support & ran into these comments. And expanding test coverage would be good.