Skip to content

Fix --build_wasm_static_lib implicitly enable --build_wasm #27342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −3
Open

Fix --build_wasm_static_lib implicitly enable --build_wasm #27342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f37c4
Initial plan
Copilot Feb 13, 2026
69306d9
Make --build_wasm_static_lib implicitly enable --build_wasm
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tools/ci_build/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2346,9 +2346,6 @@ def main():
if args.nnapi_min_api < 27:
raise BuildError("--nnapi_min_api should be 27+")

if args.build_wasm_static_lib:
args.build_wasm = True

if args.build_wasm:
if not args.disable_wasm_exception_catching and args.disable_exceptions:
# When '--disable_exceptions' is set, we set '--disable_wasm_exception_catching' as well
Expand Down
4 changes: 4 additions & 0 deletions tools/ci_build/build_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,10 @@ def convert_arg_line_to_args(self, arg_line: str) -> list[str]: # Use list[str]
if args.android_ndk_path:
args.android_ndk_path = os.path.normpath(args.android_ndk_path)

# Treat --build_wasm_static_lib as implying --build_wasm
if args.build_wasm_static_lib:
args.build_wasm = True

# Handle WASM exception logic
if args.enable_wasm_api_exception_catching:
args.disable_wasm_exception_catching = True # Catching at API level implies disabling broader catching
Expand Down
Loading