Add new config prop populateGitInfo #34329
Conversation
This comment has been minimized.
This comment has been minimized.
|
@yury-s thanks for the review.
|
This comment has been minimized.
This comment has been minimized.
| @@ -64,6 +64,12 @@ See [`property: TestConfig.maxFailures`]. | |||
|
|
|||
| See [`property: TestConfig.metadata`]. | |||
|
|
|||
| ## property: FullConfig.populateGitInfo | |||
There was a problem hiding this comment.
We try to not add new properties to FullConfig unless there is a strong need for it. Can you store it as FullConfigInternal.populateGitInfo instead ? Should be similar to tsconfig.
| @@ -321,6 +321,22 @@ This path will serve as the base directory for each test file snapshot directory | |||
| ## property: TestConfig.snapshotPathTemplate = %%-test-config-snapshot-path-template-%% | |||
| * since: v1.28 | |||
|
|
|||
| ## property: TestConfig.populateGitInfo | |||
| * since: v1.50 | |||
There was a problem hiding this comment.
| * since: v1.50 | |
| * since: v1.51 |
We are going to cut 1.50 branch in the next few days and would like to push this feature to the next release.
| * since: v1.50 | ||
| - type: ?<[boolean]> | ||
|
|
||
| Whether to populate [`property: TestConfig.metadata`] with Git info. |
There was a problem hiding this comment.
Maybe also mention that the metadata will automatically appear in the html report, otherwise it's not clear what the use of the option?
| @@ -70,6 +71,8 @@ export class Runner { | |||
| const config = this._config; | |||
| const listOnly = config.cliListOnly; | |||
|
|
|||
| addGitCommitInfoPlugin(config); | |||
There was a problem hiding this comment.
We'll also need similar call in testServer.ts, so that it works in UI mode and with the extension. Let's add a UI mode test for the property.
Test results for "tests 1"7 flaky37606 passed, 648 skipped Merge workflow run. |
Fixes #34094