-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: add new config prop populateGitInfo #34329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dgozman
merged 11 commits into
microsoft:main
from
vitalets:test-config-populate-git-info
Jan 28, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9cd33a7
Add new config prop populateGitInfo, see #34094
vitalets 2a7ec73
use markdown-first way and inverse deps
vitalets 7e18ec1
Merge branch 'microsoft:main' into test-config-populate-git-info
vitalets 7355ed3
removed from full config, set ver 1.51 and handle ui mode
vitalets 6042395
fix lint
vitalets 55fd34a
remove test.only
vitalets 203951e
Merge branch 'microsoft:main' into test-config-populate-git-info
vitalets b311a38
improve test for git info in ui mode
vitalets d50291c
fix assertion in ui mode
vitalets c00e781
Reuse metadata instance between FullConfigInternal instances
yury-s 2b6b01c
remove comments
vitalets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/** | ||
* Copyright (c) Microsoft Corporation. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { test, expect } from './ui-mode-fixtures'; | ||
|
||
test('should render html report git info metadata', async ({ runUITest }) => { | ||
const { page } = await runUITest({ | ||
'reporter.ts': ` | ||
module.exports = class Reporter { | ||
onBegin(config, suite) { | ||
console.log('ci.link:', config.metadata['ci.link']); | ||
} | ||
} | ||
`, | ||
'playwright.config.ts': ` | ||
import { defineConfig } from '@playwright/test'; | ||
export default defineConfig({ | ||
populateGitInfo: true, | ||
reporter: './reporter.ts', | ||
}); | ||
`, | ||
'a.test.js': ` | ||
import { test, expect } from '@playwright/test'; | ||
test('should work', async ({}) => {}); | ||
` | ||
}, { | ||
BUILD_URL: 'https://playwright.dev', | ||
}); | ||
|
||
await page.getByTitle('Run all').click(); | ||
await expect(page.getByTestId('status-line')).toHaveText('1/1 passed (100%)'); | ||
await page.getByTitle('Toggle output').click(); | ||
|
||
await expect(page.getByTestId('output')).toContainText('ci.link: https://playwright.dev'); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.