chore: add toHaveClass partial option #35229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
toHaveClass-partial
branch
from
b5d4889 to
395db83
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
toHaveClass-partial
branch
from
395db83 to
adc3ded
Compare
dgozman
reviewed
Mar 17, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
toHaveClass-partial
branch
2 times, most recently
from
7d89bc5 to
0a73c70
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Mar 19, 2025
| @@ -1523,6 +1523,12 @@ Expected class or RegExp or a list of those. | |||
|
|
|||
| Expected class or RegExp or a list of those. | |||
|
|
|||
| ### option: LocatorAssertions.toHaveClass.partial | |||
There was a problem hiding this comment.
A topic for the API review: does not.toHaveClass('foo bar', { partial: true }) match the class name foo baz?
mxschmitt
force-pushed
the
toHaveClass-partial
branch
from
0a73c70 to
48d58d2
Compare
dgozman
approved these changes
Mar 20, 2025
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"3 flaky38797 passed, 808 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously added in #15491 but reverted. The difference to the previous implementation is that its not a separate expect matcher its rather just a new option
partial: booleanwhich is by default false. This option works when passing astringand astring[].Relates #14117