Added reset of the color palete before creating milestones #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR ensures milestones receive consistent colors by resetting the color palette to its initial state before milestone creation. The change addresses an issue where the color palette's internal state was being consumed by task creation, causing milestones to receive different colors depending on the number of tasks.
Key changes:
- Reordered
createMilestonescall to occur aftercreateTasks - Added
colorPalette.reset()call before creating milestones to ensure consistent color assignment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const tasks: Task[] = this.createTasks({ dataView, taskTypes: legendTypes, formatters, taskColor, isEndDateFilled, hasHighlights: this.hasHighlights, sortingOptions }); | ||
|
|
||
| // resetting color palette to initial state |
There was a problem hiding this comment.
Spelling error in comment: "palete" should be "palette".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.