Skip to content

[hpx] Release V1.11.0#46221

Merged
BillyONeal merged 11 commits intomicrosoft:masterfrom
STEllAR-GROUP:master
Aug 5, 2025
Merged

[hpx] Release V1.11.0#46221
BillyONeal merged 11 commits intomicrosoft:masterfrom
STEllAR-GROUP:master

Conversation

@hkaiser
Copy link
Copy Markdown
Contributor

@hkaiser hkaiser commented Jun 29, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W self-assigned this Jun 30, 2025
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jun 30, 2025
@Cheney-W
Copy link
Copy Markdown
Contributor

@hkaiser
Copy link
Copy Markdown
Contributor Author

hkaiser commented Jun 30, 2025

Could you please point me to the documentation on how to disable certain features on single platforms?

@BillyONeal
Copy link
Copy Markdown
Member

Could you please point me to the documentation on how to disable certain features on single platforms?

If they are intended to not work for everyone you can use "supports" to mark them that way.

For example, to the "cuda" feature you can add "supports": "!linux & !(windows&arm)".

If they are expected to work but they don't due to something about how our test lab is set up you can look to scripts/ci.feature.baseline.txt.

@vicroms vicroms requested a review from Copilot July 2, 2025 22:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps HPX to version 1.11.0 and updates related metadata.

  • Adds version 1.11.0 to the versions database
  • Updates the CI baseline to 1.11.0
  • Bumps vcpkg.json to 1.11.0 and resets port-version to 0
  • Updates the GitHub archive SHA512 in portfile.cmake

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
versions/h-/hpx.json Insert new 1.11.0 version entry
versions/baseline.json Update HPX baseline to 1.11.0, port-version 0
ports/hpx/vcpkg.json Bump version to 1.11.0, drop explicit port-version
ports/hpx/portfile.cmake Update SHA512 checksum for the new release

vicroms
vicroms previously requested changes Jul 4, 2025
Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like feature mpi is failing tests because msmpi does not build for ARM64 Windows triplets. Please modify the baseline to reflect this cascade failure.

Please review the build failure logs

There are some feature test problems!
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:150:1: error: hpx[core,mpi]:arm64-windows was unexpectedly a cascading failure because the following dependencies are unavailable: mpi[core]:arm64-windows
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:150:1: note: consider changing this to =cascade instead
D:\a\_work\1\s\scripts\azure-pipelines\test-modified-ports.ps1 : vcpkg feature testing failed; this is usually a bug in one of the features in the port(s) edited in this pull request. ```

@vicroms vicroms marked this pull request as draft July 4, 2025 09:14
@vicroms vicroms self-assigned this Jul 4, 2025
@vicroms vicroms added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 4, 2025
Comment thread scripts/ci.feature.baseline.txt Outdated
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jul 20, 2025

@hkaiser I'm unable to push changes directly to your master branch.

The following triplets contain conflictive entries on ci.feature.baseline.txt

D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:970:1: error: 'hpx' was already declared as 'fail'
  on expression: hpx:x64-uwp = cascade
                 ^
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:158:1: note: previous declaration was here
  on expression: hpx:x64-uwp=fail

And these two have unmarked cascade failures:

hpx[mpi](arm64 & windows) = cascade # mpi[core] fails to build on arm64-windows

@hkaiser
Copy link
Copy Markdown
Contributor Author

hkaiser commented Jul 23, 2025

@vicroms please give me the diff, I'll apply it to our branch.

@BillyONeal
Copy link
Copy Markdown
Member

It looks like the majority of failures are due to HPX_WITH_GENERIC_CONTEXT_COROUTINES=ON getting set, that activating code wanting a function get_stack_ptr to exist, and that function not existing as far as I can tell.

Recent PR touching this area: TheHPXProject/hpx#6594 @isidorostsa @hkaiser

In particular, https://github.com/STEllAR-GROUP/hpx/blob/0c07c0774587a4accad53de3b394699e6a262e66/libs/core/coroutines/include/hpx/coroutines/detail/get_stack_pointer.hpp#L14-L16 appears to set HPX_HAVE_THREADS_GET_STACK_POINTER despite not actually providing a declaration of get_stack_ptr for Windows.

On the (working) x64-windows builds, this is masked by HPX_WITH_GENERIC_CONTEXT_COROUTINES getting set to OFF. Probably by this block:

https://github.com/STEllAR-GROUP/hpx/blob/0c07c0774587a4accad53de3b394699e6a262e66/CMakeLists.txt#L1769-L1772

@BillyONeal
Copy link
Copy Markdown
Member

@hkaiser I submitted fixes to STEllAR-GROUP#1 because we can't push here.

I'm not 100% positive I fixed everything but I manually tested x-test-features for these:

  • x86-windows (which works)
  • x64-windows (also works)
  • x64-windows-static (skipped)
  • x64-windows-static-md (works)
  • arm64-windows (skipped)
  • x64-uwp (skipped because the dependency hwloc does not support uwp)

@BillyONeal BillyONeal removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 31, 2025
Fix supports clause and baselines
@hkaiser
Copy link
Copy Markdown
Contributor Author

hkaiser commented Jul 31, 2025

@hkaiser I submitted fixes to STEllAR-GROUP#1 because we can't push here.

I'm not 100% positive I fixed everything but I manually tested x-test-features for these:

  • x86-windows (which works)
  • x64-windows (also works)
  • x64-windows-static (skipped)
  • x64-windows-static-md (works)
  • arm64-windows (skipped)
  • x64-uwp (skipped because the dependency hwloc does not support uwp)

I merged your patch, thanks!

@BillyONeal
Copy link
Copy Markdown
Member

I opened #46695 and will make sure everything works before pinging you again :)

@BillyONeal
Copy link
Copy Markdown
Member

Sorry I missed a few things, STEllAR-GROUP#2 fixes the rest of it. Thanks for the port update and sorry it took a bit to get things working :)

@BillyONeal BillyONeal marked this pull request as ready for review August 1, 2025 18:22
@BillyONeal
Copy link
Copy Markdown
Member

(as an aside, in the future if you open this from a branch other than master and check the 'allow maintainers to edit' box we might be able to fix stuff like this without bothering you next time :) )

@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 2, 2025
@BillyONeal
Copy link
Copy Markdown
Member

@hkaiser Sorry for the accident the first time, is there anything else I can do to help unblock this for you?

@hkaiser
Copy link
Copy Markdown
Contributor Author

hkaiser commented Aug 4, 2025

@hkaiser Sorry for the accident the first time, is there anything else I can do to help unblock this for you?

Thanks for all your help! I think we're good now.

More small baseline fixes
@BillyONeal BillyONeal dismissed vicroms’s stale review August 4, 2025 23:16

The requested changes have been made.

@BillyONeal BillyONeal enabled auto-merge (squash) August 4, 2025 23:16
@BillyONeal BillyONeal merged commit 8da671e into microsoft:master Aug 5, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants