Conversation
|
Could you please point me to the documentation on how to disable certain features on single platforms? |
If they are intended to not work for everyone you can use For example, to the "cuda" feature you can add If they are expected to work but they don't due to something about how our test lab is set up you can look to |
There was a problem hiding this comment.
Pull Request Overview
This PR bumps HPX to version 1.11.0 and updates related metadata.
- Adds version 1.11.0 to the versions database
- Updates the CI baseline to 1.11.0
- Bumps
vcpkg.jsonto 1.11.0 and resets port-version to 0 - Updates the GitHub archive SHA512 in
portfile.cmake
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| versions/h-/hpx.json | Insert new 1.11.0 version entry |
| versions/baseline.json | Update HPX baseline to 1.11.0, port-version 0 |
| ports/hpx/vcpkg.json | Bump version to 1.11.0, drop explicit port-version |
| ports/hpx/portfile.cmake | Update SHA512 checksum for the new release |
vicroms
left a comment
There was a problem hiding this comment.
Seems like feature mpi is failing tests because msmpi does not build for ARM64 Windows triplets. Please modify the baseline to reflect this cascade failure.
Please review the build failure logs
There are some feature test problems!
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:150:1: error: hpx[core,mpi]:arm64-windows was unexpectedly a cascading failure because the following dependencies are unavailable: mpi[core]:arm64-windows
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:150:1: note: consider changing this to =cascade instead
D:\a\_work\1\s\scripts\azure-pipelines\test-modified-ports.ps1 : vcpkg feature testing failed; this is usually a bug in one of the features in the port(s) edited in this pull request. ```
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
|
@hkaiser I'm unable to push changes directly to your The following triplets contain conflictive entries on And these two have unmarked cascade failures: |
|
@vicroms please give me the diff, I'll apply it to our branch. |
|
It looks like the majority of failures are due to Recent PR touching this area: TheHPXProject/hpx#6594 @isidorostsa @hkaiser In particular, https://github.com/STEllAR-GROUP/hpx/blob/0c07c0774587a4accad53de3b394699e6a262e66/libs/core/coroutines/include/hpx/coroutines/detail/get_stack_pointer.hpp#L14-L16 appears to set On the (working) x64-windows builds, this is masked by |
|
@hkaiser I submitted fixes to STEllAR-GROUP#1 because we can't push here. I'm not 100% positive I fixed everything but I manually tested
|
Fix supports clause and baselines
I merged your patch, thanks! |
|
I opened #46695 and will make sure everything works before pinging you again :) |
|
Sorry I missed a few things, STEllAR-GROUP#2 fixes the rest of it. Thanks for the port update and sorry it took a bit to get things working :) |
|
(as an aside, in the future if you open this from a branch other than |
|
@hkaiser Sorry for the accident the first time, is there anything else I can do to help unblock this for you? |
Thanks for all your help! I think we're good now. |
More small baseline fixes
The requested changes have been made.
./vcpkg x-add-version --alland committing the result.