[libfyaml] new port, [appstream] update to 1.1.2#51490
[libfyaml] new port, [appstream] update to 1.1.2#51490brunvonlope wants to merge 2 commits intomicrosoft:masterfrom
Conversation
brunvonlope
force-pushed
the
bruno/libfyaml-test
branch
3 times, most recently
from
a2cc5c0 to
a38f3a7
Compare
|
Drafting due to build failures in the new port. |
brunvonlope
force-pushed
the
bruno/libfyaml-test
branch
4 times, most recently
from
70c3ef2 to
778012a
Compare
brunvonlope
force-pushed
the
bruno/libfyaml-test
branch
6 times, most recently
from
3e113bd to
91a61d4
Compare
brunvonlope
force-pushed
the
bruno/libfyaml-test
branch
3 times, most recently
from
492d07b to
f41ce33
Compare
|
@BillyONeal May be in decent shape for review now :) |
| set(VCPKG_C_FLAGS "${VCPKG_C_FLAGS} -Wno-error=incompatible-pointer-types") | ||
| set(VCPKG_CXX_FLAGS "${VCPKG_CXX_FLAGS} -Wno-error=incompatible-pointer-types") |
There was a problem hiding this comment.
Usually we want to get rid of -Werror.
There was a problem hiding this comment.
Could you rephrase? I did not get it
There was a problem hiding this comment.
AFAIU these lines disable -Wno-error for a particular warning. I see that as a symptom of -Werror being used during the port build. (Correct me if I'm wrong.)
In general, it is not desired to have -Werror in port builds. That flags is a helpful tool in controlled environments (i.e. upstream CI, or actual developer). But it is breaking builds too easily when toolchains, targets and time vary over a wide range.
So I suggest to check the buildsystem and logs for signs of -Werror, and to disable that flag.
| -set(CMAKE_THREAD_PREFER_PTHREAD TRUE) | ||
| -set(THREADS_PREFER_PTHREAD_FLAG TRUE) | ||
| -find_dependency(Threads REQUIRED) | ||
| +if(NOT WIN32 AND NOT ANDROID) |
There was a problem hiding this comment.
Again, the patching shouldn't be necessary.
There was a problem hiding this comment.
Again, already responded in the comment above. I would not patch something unnecessary.
If you have a alternative fix for android, please push a commit
brunvonlope
force-pushed
the
bruno/libfyaml-test
branch
2 times, most recently
from
56c3e87 to
abef147
Compare
Needed for appstream port
brunvonlope
force-pushed
the
bruno/libfyaml-test
branch
from
0f7cecc to
e794cd9
Compare
3 participants
./vcpkg x-add-version --alland committing the result.