Skip to content

engineering: use tar+zstd for win32 node_modules cache #291624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lszomoru merged 9 commits into from
Jan 29, 2026
Merged

engineering: use tar+zstd for win32 node_modules cache #291624

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fbbe2b2
engineering: use tar+zstd for win32 node_modules cache
tmm1 Aug 6, 2025
0c69046
bump cache
tmm1 Aug 6, 2025
f7ec839
Merge branch 'main' into tmm1/faster-win32-nodemodules
joaomoreno Jan 29, 2026
a6b4b6f
Update .github/workflows/pr-node-modules.yml
joaomoreno Jan 29, 2026
ce60143
Update build/azure-pipelines/win32/product-build-win32-node-modules.yml
joaomoreno Jan 29, 2026
bb86d40
Update build/azure-pipelines/win32/steps/product-build-win32-compile.yml
joaomoreno Jan 29, 2026
5ebc85d
Update .github/workflows/pr-win32-test.yml
joaomoreno Jan 29, 2026
7e2f7a6
bump cache salt
joaomoreno Jan 29, 2026
ba04fdf
more fixes
joaomoreno Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-node-modules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,4 +282,4 @@ jobs:
$ErrorActionPreference = "Stop"
exec { node build/azure-pipelines/common/listNodeModules.ts .build/node_modules_list.txt }
exec { mkdir -Force .build/node_modules_cache }
exec { 7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt }
exec { & "C:\Program Files\Git\usr\bin\tar.exe" --posix -cf .build/node_modules_cache/cache.tzst --exclude cache.tzst -C . --files-from .build/node_modules_list.txt --force-local --use-compress-program "zstd -T0" }
4 changes: 2 additions & 2 deletions .github/workflows/pr-win32-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Extract node_modules cache
if: steps.node-modules-cache.outputs.cache-hit == 'true'
shell: pwsh
run: 7z.exe x .build/node_modules_cache/cache.7z -aoa
run: '& "C:\Program Files\Git\usr\bin\tar.exe" -xf .build/node_modules_cache/cache.tzst -C . --force-local --use-compress-program "zstd -d"'

- name: Install dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
$ErrorActionPreference = "Stop"
exec { node build/azure-pipelines/common/listNodeModules.ts .build/node_modules_list.txt }
exec { mkdir -Force .build/node_modules_cache }
exec { 7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt }
exec { & "C:\Program Files\Git\usr\bin\tar.exe" --posix -cf .build/node_modules_cache/cache.tzst --exclude cache.tzst -P -C . --files-from .build/node_modules_list.txt --force-local --use-compress-program "zstd -T0" }

- name: Create .build folder
shell: pwsh
Expand Down
2 changes: 1 addition & 1 deletion build/.cachesalt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026-01-23T20:55:53.631Z
2026-01-29T15:14:58.453Z
2 changes: 1 addition & 1 deletion build/azure-pipelines/win32/product-build-win32-node-modules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,6 @@ jobs:
$ErrorActionPreference = "Stop"
exec { node build/azure-pipelines/common/listNodeModules.ts .build/node_modules_list.txt }
exec { mkdir -Force .build/node_modules_cache }
exec { 7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt }
exec { & "C:\Program Files\Git\usr\bin\tar.exe" --posix -cf .build/node_modules_cache/cache.tzst --exclude cache.tzst -C . --files-from .build/node_modules_list.txt --force-local --use-compress-program "zstd -T0" }
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
displayName: Create node_modules archive
4 changes: 2 additions & 2 deletions build/azure-pipelines/win32/steps/product-build-win32-compile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ steps:
cacheHitVar: NODE_MODULES_RESTORED
displayName: Restore node_modules cache

- powershell: 7z.exe x .build/node_modules_cache/cache.7z -aoa
- powershell: '& "C:\Program Files\Git\usr\bin\tar.exe" -xf .build/node_modules_cache/cache.tzst -C . --force-local --use-compress-program "zstd -d"'
condition: and(succeeded(), eq(variables.NODE_MODULES_RESTORED, 'true'))
displayName: Extract node_modules cache

Expand Down Expand Up @@ -110,7 +110,7 @@ steps:
$ErrorActionPreference = "Stop"
exec { node build/azure-pipelines/common/listNodeModules.ts .build/node_modules_list.txt }
exec { mkdir -Force .build/node_modules_cache }
exec { 7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt }
exec { & "C:\Program Files\Git\usr\bin\tar.exe" --posix -cf .build/node_modules_cache/cache.tzst --exclude cache.tzst -P -C . --files-from .build/node_modules_list.txt --force-local --use-compress-program "zstd -T0" }
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
displayName: Create node_modules archive

Expand Down
Loading