engineering: use tar+zstd for win32 node_modules cache#291624
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces 7-Zip compression with tar+zstd for Windows node_modules caching to significantly improve CI/CD performance. According to the PR description, this reduces the Extract node_modules phase from 120-180 seconds to 60 seconds. Both tar.exe and zstandard are bundled in GitHub Actions and Azure Pipelines Windows images, making this change feasible without additional tooling requirements.
Changes:
- Replaced all 7z.exe commands with tar+zstd commands across GitHub Actions and Azure Pipelines workflows
- Changed cache file extension from
.7zto.tzst - Updated
.cachesalttimestamp to invalidate existing caches
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pr-win32-test.yml |
Updated extraction and creation commands to use tar+zstd instead of 7z |
.github/workflows/pr-node-modules.yml |
Updated Windows job creation command to use tar+zstd instead of 7z |
build/azure-pipelines/win32/steps/product-build-win32-compile.yml |
Updated extraction and creation commands to use tar+zstd instead of 7z |
build/azure-pipelines/win32/product-build-win32-node-modules.yml |
Updated creation command to use tar+zstd instead of 7z |
build/.cachesalt |
Bumped timestamp to invalidate old 7z-based caches |
TylerLeonhardt
approved these changes
Jan 29, 2026
rzhao271
approved these changes
Jan 29, 2026
lszomoru
approved these changes
Jan 29, 2026
Collaborator
|
This change broke CI for #291731. Reverting. |
rzhao271
added a commit
that referenced
this pull request
Jan 29, 2026
…)" This reverts commit 7052972.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from @tmm1: