Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app and SP owners and other updates #218

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Add app and SP owners and other updates #218

merged 3 commits into from
Feb 11, 2025

Conversation

jason-dou
Copy link
Collaborator

@jason-dou jason-dou commented Feb 4, 2025 •
edited by microsoft-github-policy-service bot
Loading

  • Add app and sp owners
  • Mark subject as non-required in applications/federatedIdentityCredentials@beta with the introduction of claimsMatchingExpression
Microsoft Reviewers: Open in CodeFlow

@jason-dou jason-dou requested a review from a team as a code owner February 4, 2025 00:32
eketo-msft
eketo-msft previously approved these changes Feb 4, 2025
View reviewed changes
@jason-dou jason-dou requested a review from dkershaw10 February 11, 2025 19:35
dkershaw10
dkershaw10 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@dkershaw10 dkershaw10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-dou jason-dou merged commit c9f712f into main Feb 11, 2025
6 checks passed
@jason-dou jason-dou deleted the jasondou/appsp-owners branch February 11, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkershaw10 dkershaw10 dkershaw10 approved these changes

@eketo-msft eketo-msft eketo-msft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-dou @dkershaw10 @eketo-msft