feat: move from tsd to tstyche appconfig

[Puppo]

• Move appConfig from tsd to tstyche

[Puppo]

This one allows us to keep both systems during the migration, and run the tests only where they are available for that framework.

[mrazauskas]

A quick note, you can use .not.toBeCallableWith() instead of // @ts-expect-error. The matcher indicates the purpose of a test somewhat better.

[mrazauskas]

Suggested change

	// @ts-expect-error - fetchData must be an object
	appConfig({ ...options, fetchData: "not-an-object" });
	expect(appConfig).type.not.toBeCallableWith({
	...options,
	fetchData: "not-an-object",
	});

[mrazauskas]

Suggested change

	appConfig({
	...options,
	fetchData: {
	config: {
	// @ts-expect-error - Application must be a string
	ApplicationIdentifier: 123,
	// @ts-expect-error - Configuration must be a string
	ConfigurationProfileIdentifier: 123,
	// @ts-expect-error - Environment must be a string
	EnvironmentIdentifier: 123,
	},
	},
	});
	expect(appConfig).type.not.toBeCallableWith({
	...options,
	fetchData: {
	config: {
	ApplicationIdentifier: 123,
	ConfigurationProfileIdentifier: 123,
	EnvironmentIdentifier: 123,
	},
	},
	});

[mrazauskas]

Suggested change

	appConfig({
	...options,
	fetchData: {
	// @ts-expect-error - config must contain Application, ClientId, Configuration and Environment
	config: {},
	},
	});
	expect(appConfig).type.not.toBeCallableWith({
	...options,
	fetchData: {
	config: {},
	},
	});

[mrazauskas]

Suggested change

	"test:types:tstyche": "find packages -name \"*.tst.ts\" -exec dirname {} \\; | sed 's|packages/||' | sort -u | xargs -I {} tstyche packages/{}",
	"test:types:tstyche": "tstyche",

[mrazauskas]

If you stick with the *.tst.ts pattern, TSTyche will handle that.

[mrazauskas]

How can it be that extension less imports are still allowed? Ah.. The root ./tsconfig.json makes this work. It defaults to CJS resolution. Is that useful for any other tooling?

I see two options:

• npm run test:types:tstyche -- --tsconfig ignore, simply use TSTyche defaults;
• extend the root TSConfig from @tsconfig/node20, since Node.js 20 is the lowest supported version

[mrazauskas]

The extension less imports should fail after badad62. (Many thanks to @willfarrell!)

[mrazauskas]

Perhaps? And remember to import the AppConfigOptions type:

Suggested change

	} as const;
	} satisfies AppConfigOptions;

[willfarrell]

#1384 has been merged in. The new approach looks way easier to understand. With no comments against moving forward, I would say feel free to move forward with all middlewares if you like,