chore: extend from @tsconfig/node20
#1384
Conversation
| @@ -1,5 +1,5 @@ | |||
| import { expectType } from "tsd"; | |||
| import type { transpileLocale, transpileSchema } from "./transpile.t.ds"; | |||
There was a problem hiding this comment.
These are obviously not type only imports. The problem is that current TSConfig defaults to moduleResolution: "node10" and that allows oddities like this one.
There was a problem hiding this comment.
Oh.. All is even worse. Seems like tsd does not check this file. It only picks up index.test-d.ts.
|
@willfarrell Could you take a look, please. The branch is rebased and all conflicts are resolved now. |
|
Great. Looks like it just needs |
|
Unfortunate the Nothing personal. I just think this DCO check (or whatever it is called) is a waste of time for minor improvements like the one I was suggesting here. |
|
I can take care of it for you, one sec. |
Closes #1384 Signed-off-by: will Farrell <[email protected]>
|
v6.4.0 will release shortly. PS I don't use git either :). signoff It's a checkbox in |
|
Thanks for taking care! Hm.. What is that |
|
I'm sure there is a free alt out there. |
2 participants
This aim of this PR is to make the root TSConfig stricter.
I would suggest extending from
@tsconfig/node20. The other changes you see here are the result of this improvement.This should help to modernize the type testing infrastructure in the future (e.g. #1383 or similar).