Update Scroller When Exists - Fix Layout Exception - #382
Merged
migueldeicaza merged 1 commit intoJul 15, 2025
Merged
Conversation
Owner
|
Thank you for your fix! |
Comment on lines
-306
to
-307
| if scroller != nil { | ||
| scroller.removeFromSuperview() |
Contributor
There was a problem hiding this comment.
That is a workaround for the scroller not responding to frame updates. Without re-adding the scroller, it does not layout properly. I introduced the workarond here #362
Now when it is reverted, the previous problem reappeared.
min-median-max
pushed a commit
to min-median-max/SwiftTerm
that referenced
this pull request
Jan 18, 2026
…break-swiftui Update Scroller When Exists - Fix Layout Exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a layout exception due to the removal of the scroller during constraint layout. This happened when the view was embedded in a SwiftUI view and SwiftUI attempted to update its frame, which caused the scroller to be removed from the view hierarchy which is illegal.
To fix I just removed the removal of the old scroller and updated its frame if it's not
nil. This avoids a view tree update and still updates the scroller's position and size.