Skip to content

Update Scroller When Exists - Fix Layout Exception #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
migueldeicaza merged 1 commit into from
Jul 15, 2025
Merged

Update Scroller When Exists - Fix Layout Exception #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Sources/SwiftTerm/Mac/MacTerminalView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,13 +303,14 @@ open class TerminalView: NSView, NSTextInputClient, NSUserInterfaceValidations,

func setupScroller()
{
if scroller != nil {
scroller.removeFromSuperview()
Comment on lines -306 to -307

@krzyzanowskim krzyzanowskim Aug 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a workaround for the scroller not responding to frame updates. Without re-adding the scroller, it does not layout properly. I introduced the workarond here #362
Now when it is reverted, the previous problem reappeared.

}

let style: NSScroller.Style = .legacy
let scrollerWidth = NSScroller.scrollerWidth(for: .regular, scrollerStyle: style)
scroller = NSScroller(frame: NSRect(x: bounds.maxX - scrollerWidth, y: 0, width: scrollerWidth, height: bounds.height))
let scrollerFrame = NSRect(x: bounds.maxX - scrollerWidth, y: 0, width: scrollerWidth, height: bounds.height)
if scroller == nil {
scroller = NSScroller(frame: scrollerFrame)
} else {
scroller?.frame = scrollerFrame
}
scroller.autoresizingMask = [.minXMargin, .height]
scroller.scrollerStyle = style
scroller.knobProportion = 0.1
Expand Down
Loading